Skip to content

Migrate climate attributes to own entities in AVM Fritz!SmartHome #38655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Apr 21, 2025

Proposed change

SSIA

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Streamlined the FRITZ!Box integration documentation by replacing detailed attribute tables with a concise list of available sensors and binary sensors.
    • Expanded the list to explicitly mention "Battery low," "Holiday mode," "Open window detected," and "Summer mode" as available entities.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 21, 2025
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 5418fec
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/68062cebdb54f20008cdcf1d
😎 Deploy Preview https://deploy-preview-38655--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 21, 2025

📝 Walkthrough

Walkthrough

The documentation for the FRITZ!Box integration was updated to streamline the presentation of thermostat climate entity attributes. The previous detailed attribute table was removed and replaced with a concise list format. The documentation now enumerates related sensor and binary_sensor entities that can be created for each device, explicitly listing capabilities such as "Battery low," "Holiday mode," "Open window detected," and "Summer mode." These changes were applied to both the thermostat and "Other devices" sections, resulting in a more concise and consistent documentation style.

Changes

File(s) Change Summary
source/_integrations/fritzbox.markdown Replaced detailed attribute table for thermostat climate entities with a concise list of sensor entities; expanded and clarified the list of additional sensors and binary sensors for thermostats and other devices.

Sequence Diagram(s)

No sequence diagram is generated as the changes are limited to documentation restructuring and do not affect control flow or feature logic.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46be8fb and 5418fec.

📒 Files selected for processing (1)
  • source/_integrations/fritzbox.markdown (2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fritzbox.markdown

[duplication] ~114-~114: Possible typo: you repeated a word.
Context: ...lates %}, based on its capabilities: - Battery - Battery low - Button lock via UI - Button lock ...

(ENGLISH_WORD_REPEAT_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/fritzbox.markdown (3)

112-127: Thermostat sensor list updates look accurate and complete.

The added entries for “Battery low”, “Holiday mode”, “Open window detected”, and “Summer mode” correctly map the migrated climate attributes to their own entities.

🧰 Tools
🪛 LanguageTool

[duplication] ~114-~114: Possible typo: you repeated a word.
Context: ...lates %}, based on its capabilities: - Battery - Battery low - Button lock via UI - Button lock ...

(ENGLISH_WORD_REPEAT_RULE)


114-114: Ignore the false-positive duplication hint.

The terms “Battery” and “Battery low” are intentionally distinct capabilities, not a typo.

🧰 Tools
🪛 LanguageTool

[duplication] ~114-~114: Possible typo: you repeated a word.
Context: ...lates %}, based on its capabilities: - Battery - Battery low - Button lock via UI - Button lock ...

(ENGLISH_WORD_REPEAT_RULE)


132-142: Other devices sensor list updates look good.

Including “Battery low” and “Open window detected” in the Other devices section aligns with the new entity‐migration changes.

🧰 Tools
🪛 LanguageTool

[duplication] ~134-~134: Possible typo: you repeated a word.
Context: ...evice and can be one or multiple of: - Battery - Battery low - Button lock via UI - Button lock ...

(ENGLISH_WORD_REPEAT_RULE)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mib1185 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants