Skip to content

update config flow for ecobee#45087

Merged
c0ffeeca7 merged 5 commits intohome-assistant:currentfrom
ch604:current
May 4, 2026
Merged

update config flow for ecobee#45087
c0ffeeca7 merged 5 commits intohome-assistant:currentfrom
ch604:current

Conversation

@ch604
Copy link
Copy Markdown
Contributor

@ch604 ch604 commented Apr 29, 2026

Proposed change

ecobee integration config flow now accepts username and password

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copilot AI review requested due to automatic review settings April 29, 2026 16:15
@home-assistant home-assistant Bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 29, 2026
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Apr 29, 2026

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 4114b9f
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/69f831fd3d291100087d7746
😎 Deploy Preview https://deploy-preview-45087--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ch604 ch604 mentioned this pull request Apr 29, 2026
Closed
@ch604
Copy link
Copy Markdown
Contributor Author

ch604 commented Apr 29, 2026

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

the parent PR was merged some 2 months ago and is live, so i believe the current branch is correct.

Copilot AI reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ecobee integration documentation to reflect the updated Home Assistant config flow that supports signing in with an ecobee username and password (and no longer requires creating a developer API key for new setups).

Changes:

  • Removes the legacy “Preliminary steps” and manual API-key-based setup instructions.
  • Adds a note explaining that a developer API key is no longer required and updates the documented config flow fields.
  • Minor markup change in the image block.

Comment thread source/_integrations/ecobee.markdown Outdated
Comment thread source/_integrations/ecobee.markdown Outdated
Comment thread source/_integrations/ecobee.markdown Outdated
@c0ffeeca7 c0ffeeca7 added the parent-merged The parent PR has been merged already label Apr 30, 2026
c0ffeeca7
c0ffeeca7 requested changes Apr 30, 2026
View reviewed changes
Comment thread source/_integrations/ecobee.markdown Outdated
@home-assistant home-assistant Bot marked this pull request as draft April 30, 2026 08:01
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Apr 30, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

c0ffeeca7
c0ffeeca7 requested changes Apr 30, 2026
View reviewed changes
Comment thread source/_integrations/ecobee.markdown Outdated
Comment thread source/_integrations/ecobee.markdown
@ch604 ch604 marked this pull request as ready for review April 30, 2026 14:32
@home-assistant home-assistant Bot requested a review from c0ffeeca7 April 30, 2026 14:32
c0ffeeca7
c0ffeeca7 requested changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny style tweaks

Comment thread source/_integrations/ecobee.markdown Outdated
Comment thread source/_integrations/ecobee.markdown Outdated
@home-assistant home-assistant Bot marked this pull request as draft April 30, 2026 14:47
@c0ffeeca7
tweaks
4114b9f 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review May 4, 2026 05:43
@home-assistant home-assistant Bot requested a review from c0ffeeca7 May 4, 2026 05:43
c0ffeeca7
c0ffeeca7 approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ch604 👍

@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) May 4, 2026 05:43
@c0ffeeca7 c0ffeeca7 merged commit 926cba5 into home-assistant:current May 4, 2026
7 checks passed
@home-assistant home-assistant Bot removed parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees

@ch604 ch604

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ch604 @c0ffeeca7 @awalilko