Closed
Create URLOpenerService protocol in Shared module#3958
Conversation
Co-authored-by: bgoncal <5808343+bgoncal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add URLOpenerService for better URL handling
Create URLOpenerService protocol in Shared module
Nov 11, 2025
Member
|
@copilot fix lint issues: |
… and wrap long lines Co-authored-by: bgoncal <5808343+bgoncal@users.noreply.github.com>
Contributor
Author
Member
|
@copilot now that the service is in Shared you had to import Shared when you use it, please double check you work and provide update. |
Contributor
Author
I've verified all files using
No changes needed - the imports were already correct from the initial implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation: URLOpenerService
This PR creates a URLOpenerService behind a protocol in the Shared module and refactors the entire app to use it instead of direct UIApplication.shared.open calls.
Plan Checklist:
Implementation Summary:
New Files Created:
Sources/Shared/Services/URLOpenerService.swift- Protocol and implementationTests/Shared/URLOpenerService.test.swift- Unit testsFiles Modified (19 total):
Architecture:
URLOpenerServiceProtocolwithopen(_:options:completionHandler:)andcanOpenURL(_:)methodsURLOpenerServiceImplthat wraps UIApplication.shared for iOS, with fallback for other platformsCurrent.urlOpenerfollowing the pattern of existing servicesBenefits:
Security Summary:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.