Conversation
Contributor
|
Found 6 unused localization strings in the codebase. Click to see detailsTo clean up these strings, manually remove them from the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy “Actions” feature surfaces across the app and widgets extension, cleaning up related settings entry points and widget implementations.
Changes:
- Removes the Actions widget(s) from the widget bundles and deletes the associated widget/provider/AppIntent code.
- Removes the legacy Actions settings screen and Settings navigation entry.
- Removes legacy Actions hooks from Magic Item add flow and stops registering the legacy Action observer on app startup.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Extensions/Widgets/Widgets.swift | Stops registering legacy Actions widgets in all widget bundles. |
| Sources/Extensions/Widgets/Actions/WidgetActionsProvider.swift | Deleted legacy intent-based timeline provider for Actions widget. |
| Sources/Extensions/Widgets/Actions/WidgetActions.swift | Deleted Actions widget implementations (AppIntent + legacy IntentConfiguration). |
| Sources/Extensions/AppIntents/WidgetActionsAppIntent.swift | Deleted Actions widget configuration AppIntent. |
| Sources/Extensions/AppIntents/Widget/Actions/WidgetActionsAppIntentTimelineProvider.swift | Deleted Actions widget AppIntent timeline provider and related datasource helpers. |
| Sources/App/Settings/Settings/SettingsView.swift | Removes the legacy Actions section from Settings UI. |
| Sources/App/Settings/Settings/SettingsItem.swift | Removes the legacy Actions settings item/case and its legacyItems list. |
| Sources/App/Settings/Settings/ActionsSettingsViewModel.swift | Deleted SwiftUI view model for legacy Actions settings screen. |
| Sources/App/Settings/Settings/ActionsSettingsView.swift | Deleted SwiftUI legacy Actions settings screen. |
| Sources/App/Settings/Settings/ActionConfiguratorView.swift | Deleted SwiftUI Action configurator/editor replacement. |
| Sources/App/Settings/Observation/Action+Observation.swift | Deleted Realm observation that previously refreshed menus/shortcuts/widgets/suggestions when Actions changed. |
| Sources/App/Settings/MagicItem/Add/MagicItemAddViewModel.swift | Removes legacy Actions support from Magic Item add view model. |
| Sources/App/Settings/MagicItem/Add/MagicItemAddView.swift | Removes legacy Actions picker option and list UI from Magic Item add flow. |
| Sources/App/AppDelegate.swift | Stops invoking Action.setupObserver() during model setup. |
| HomeAssistant.xcodeproj/project.pbxproj | Removes the deleted Actions-related source files from the Xcode project. |
| @@ -152,15 +152,6 @@ struct SettingsView: View { | |||
| } | |||
| } | |||
|
|
|||
| // Force Realm migration to happen now | ||
| _ = Realm.live() | ||
| Action.setupObserver() | ||
| NotificationCategory.setupObserver() |
Comment on lines
46
to
55
| WidgetCommonlyUsedEntities() | ||
| WidgetCustom() | ||
| WidgetAssist() | ||
| WidgetScripts() | ||
| WidgetTodoList() | ||
| WidgetGauge() | ||
| WidgetDetails() | ||
| WidgetActions() | ||
| WidgetOpenPage() | ||
| WidgetSensors() | ||
| } |
Comment on lines
7
to
12
|
|
||
| enum MagicItemAddType { | ||
| case scripts | ||
| case actions | ||
| case scenes | ||
| case entities | ||
| case assistPipelines |
Comment on lines
146
to
151
| } | ||
| } | ||
|
|
||
| @ViewBuilder | ||
| private var actionsList: some View { | ||
| actionsDeprecationDisclaimer | ||
| ForEach(viewModel.actions, id: \.ID) { action in | ||
| if visibleForSearch(title: action.Text, entityId: action.ID) { | ||
| Button(action: { | ||
| itemToAdd(.init(id: action.ID, serverId: action.serverIdentifier, type: .action)) | ||
| dismiss() | ||
| }, label: { | ||
| EntityRowView(optionalTitle: action.Text, accessoryImageSystemSymbol: .plusCircleFill) | ||
| }) | ||
| .tint(Color(uiColor: .label)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private var actionsDeprecationDisclaimer: some View { | ||
| Section { | ||
| Button { |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4584 +/- ##
=======================================
Coverage ? 43.24%
=======================================
Files ? 275
Lines ? 16700
Branches ? 0
=======================================
Hits ? 7222
Misses ? 9478
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes