Remove unused Live Activity registration fields#4586
Draft
rwarner wants to merge 2 commits intohome-assistant:mainfrom
Draft
Remove unused Live Activity registration fields#4586rwarner wants to merge 2 commits intohome-assistant:mainfrom
rwarner wants to merge 2 commits intohome-assistant:mainfrom
Conversation
HA core no longer reads or stores these fields (removed in home-assistant/core#166072 per code review). Sending unused data wastes bandwidth on every app registration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rwarner
force-pushed
the
fix/remove-unused-live-activity-registration-fields
branch
from
7582033 to
292d968
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes deprecated Live Activity support fields from the mobile app registration payload to align with updated Home Assistant Core schema and avoid sending unused data.
Changes:
- Removed
supports_live_activitiesandsupports_live_activities_frequent_updatesfromAppDataregistration payload. - Kept Live Activity push-to-start token reporting for iOS 17.2+.
Comments suppressed due to low confidence (1)
Sources/Shared/API/HAAPI.swift:566
- After removing the ActivityAuthorizationInfo usage, this file no longer references any ActivityKit types. The conditional
import ActivityKitat the top of HAAPI.swift is now unused and will produce a compiler warning; please remove that import (keeping the#if os(iOS) && canImport(ActivityKit)guards around the registration fields if still needed for LiveActivityRegistry availability).
Current.Log.info("ios component is not loaded; pretending there's no push config")
return .value(.init())
7 tasks
Now that the supports_live_activities registration fields are gone, ActivityKit types are no longer referenced in this file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4586 +/- ##
=======================================
Coverage ? 43.26%
=======================================
Files ? 275
Lines ? 16694
Branches ? 0
=======================================
Hits ? 7222
Misses ? 9472
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bgoncal
approved these changes
Apr 29, 2026
Member
|
Let's wait for the other PRs to merge it in sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supports_live_activitiesandsupports_live_activities_frequent_updatesfrom the app registration payload sent to HAThese fields were removed from the HA core side in home-assistant/core#166072 (the
SCHEMA_APP_DATAschema no longer accepts them). Sending data that the server doesn't read wastes bandwidth on every registration.Related
🤖 Generated with Claude Code