Improve native loader UI, spacing and font size - #5129
Merged
Conversation
Contributor
|
Found 5 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the native “standby/loader” overlay UI in the iOS app by adjusting spacing and typography, backed by new spacing tokens in the HADesignSystem.
Changes:
- Added larger spacing values to
DesignSystem.Spaces. - Increased bottom padding for the loader progress indicator.
- Increased font size (and styling) for the current-server pill label and the connection-type indicator icon.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Sources/HADesignSystem/Sources/Tokens/DesignSystem.swift | Adds new Spaces constants intended to support larger layout spacing. |
| Sources/App/Frontend/WebView/Views/HomeAssistantStandByView.swift | Adjusts loader spacing and updates server pill typography/icon sizing for the standby overlay UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes