Check the settings row opens the Siri screen - #5682
Merged
Merged
Conversation
Without that case the entry appears in settings and opens nothing.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly added test assertion is currently ineffective (it will always pass), so it won’t actually guard the intended regression.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a unit test to ensure the Settings “Siri” row actually navigates to a destination screen, protecting against regressions where the row remains visible but no longer opens a view.
Changes:
- Add a new test intended to verify the Siri settings row opens a destination view.
File summaries
| File | Description |
|---|---|
| Tests/App/Utilities/SiriServerExposureTests.swift | Adds a new test for the Siri settings entry destination wiring. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+89
to
+93
| /// The row has to lead somewhere: without that case the entry appears in settings and opens | ||
| /// nothing. | ||
| @MainActor @Test func theEntryOpensTheSiriScreen() { | ||
| #expect(!String(describing: SettingsItem.siri.destinationView).isEmpty) | ||
| } |
Contributor
|
Found 6 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5682 +/- ##
==========================================
+ Coverage 38.86% 39.00% +0.14%
==========================================
Files 1069 1073 +4
Lines 75564 75394 -170
==========================================
+ Hits 29371 29411 +40
+ Misses 46193 45983 -210 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Policy
Select exactly one option that describes AI usage in this contribution:
Summary
Follows #5674. The settings entry for Siri had no test covering the case that opens its screen, so removing it would leave a row that appears in settings and opens nothing.
Screenshots
Tests only.
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
No behaviour change.