"Open app" button #464
Open
"Open app" button #464
+60
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diegorro98
force-pushed
the
open_app_button
branch
from
8af4a08 to
d72adf5
Compare
Diegorro98
force-pushed
the
open_app_button
branch
from
d72adf5 to
0f91b7c
Compare
bramkragten
reviewed
Sep 4, 2024
Co-authored-by: Bram Kragten <[email protected]>
|
From what I understand, the issue currently is that on Windows the single button doesn't open the PWA. From what I know there is no alternative app on Windows? Your solution will show two buttons when there is an app installed, on every OS. Adding an extra button makes it harder for a user. I would rather avoid this scenario. Can we show a single button on Windows, when there is a PWA installed, that tries to open it there? With the assumption that you have the PWA installed for a reason and want to use that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added a button that opens the redirect link in the app.
Regular open link button and this new button are always present except if mobile param is 1, which will cause the regular button to not be displayed and the app button will be set to "Open link" to look like before the changes.
Regular open link button has been changed to "Open link here".
Also, now if the instance URL is not set yet, it will not automatically redirect to the page that changes the URL, but if the user clicks on the "Open link here" button, the user will be redirected to the page that changes the URL.