Fix ODROID-C2 USB hotplug#4669
Conversation
It seems that USB autosuspend interacting badly with dwc2 on Meson-GXBB: with nothing plugged into the GL852G's downstream ports at boot, the hub idle-suspends, and dwc2 on this SoC doesn't reliably wake on a downstream port-status-change. Devices present at boot enumerate before autosuspend kicks in. Fix by disabling USB autosuspend on this particular board.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo files are modified to add USB autosuspend delay configuration to the Odroid C2 board: a new kernel config fragment disables the delay setting, and the defconfig is updated to reference this fragment during kernel build. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This disables the USB autosuspend feature for ODROID-C2 because USB autosuspend interacting badly with dwc2 on Meson-GXBB causing USB hotplug to fail. (cf. home-assistant/operating-system#4669)
It seems that USB autosuspend interacting badly with dwc2 on Meson-GXBB: with nothing plugged into the GL852G's downstream ports at boot, the hub idle-suspends, and dwc2 on this SoC doesn't reliably wake on a downstream port-status-change. Devices present at boot enumerate before autosuspend kicks in.
Fix by disabling USB autosuspend on this particular board.
Came up during tests with Linux 6.18. The issue was already present in 6.12 and probably earlier, and also got noted in #1703 (comment).
Summary by CodeRabbit