tests: enable flake8-pytest-style (PT) ruff rules

[agners]

Proposed change

Enable the PT (flake8-pytest-style) rule set in ruff and fix the resulting violations across the test suite. The rules nudge tests toward idiomatic pytest usage and catch a few small footguns. No production code is touched and there are no behavioral changes to the tests themselves.

Concrete categories addressed:

• PT006: parametrize argument names are now tuples (("a", "b")) instead of a single comma-separated string ("a,b").
• PT022: fixtures with no teardown use return instead of yield, so the absence of cleanup is obvious at a glance and the fixture isn't wrapped in unnecessary generator/finalizer machinery.
• PT011: pytest.raises(ValueError) blocks gained a match= argument so the expected error is anchored to a specific message rather than catching any ValueError.
• PT012: setup (patches, conditional branches) was hoisted out of pytest.raises() so only the call expected to raise remains inside the block.
• PT013: from pytest import X replaced with import pytest and module-qualified access.
• PT015: try/except + assert False patterns replaced with pytest.raises(...).
• PT017: assertions on exceptions inside except blocks replaced with pytest.raises(...) as exc_info and assertions on exc_info.value.

Most of the diff is mechanical (PT006 and PT022 together account for the vast majority of the changed lines). The full test suite passes.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality to the supervisor)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:
• Link to cli pull request:
• Link to client library pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Ruff (ruff format supervisor tests)
• Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

• Documentation added/updated for developers.home-assistant.io
• CLI updated (if necessary)
• Client library updated (if necessary)

[Copilot]

Pull request overview

This PR enables Ruff’s PT (flake8-pytest-style) rules and updates the test suite to comply, primarily by tightening pytest idioms (parametrize arg naming, pytest.raises(...) usage) and simplifying fixtures that don’t need teardown.

Changes:

• Enable PT rules in Ruff and apply mechanical fixes across the test suite.
• Replace yield-only fixtures (no teardown) with return and modernize pytest imports/usages.
• Tighten exception assertions (e.g., pytest.raises(..., match=...)) and shrink raises blocks.

Reviewed changes

Copilot reviewed 77 out of 77 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pyproject.toml	Enable Ruff PT rule set.
tests/conftest.py	Convert multiple fixtures from yield to return; adjust test helpers/clients.
tests/utils/test_exception_helper.py	Convert exception assertions to pytest.raises patterns; add helpers.
tests/utils/test_dbus.py	Return fixture value instead of yielding; parametrize argnames tuple.
tests/test_validate.py	Parametrize IPv6 DNS URL test; adjust raises block.
tests/test_updater.py	Parametrize argnames tuple.
tests/test_supervisor.py	Parametrize argnames tuple.
tests/test_auth.py	Use return fixtures (no teardown).
tests/store/test_validate.py	Parametrize argnames tuple.
tests/store/test_store_manager.py	Parametrize argnames tuple (multiple tests).
tests/store/test_repository_git.py	Hoist patching out of pytest.raises tuple-context pattern.
tests/store/test_custom_repository.py	Restructure async calls to keep only the raising await inside pytest.raises.
tests/resolution/evaluation/test_evaluate_os_version.py	Parametrize argnames tuple.
tests/resolution/evaluation/test_evaluate_home_assistant_core_version.py	Parametrize argnames tuple.
tests/resolution/check/test_check_network_interface_ipv4.py	Parametrize argnames tuple (multiple).
tests/resolution/check/test_check_multiple_data_disks.py	Use return fixture (no teardown).
tests/resolution/check/test_check_disabled_data_disk.py	Use return fixture (no teardown).
tests/plugins/test_plugin_base.py	Parametrize argnames tuple (multiple).
tests/plugins/test_dns.py	Replace try/except + assert-false with pytest.raises.
tests/mounts/test_mount.py	Parametrize argnames tuple; normalize param list container.
tests/mounts/test_manager.py	Use return fixture (no teardown).
tests/misc/test_tasks.py	Use return fixture (no teardown).
tests/jobs/test_job_manager.py	Add match= to pytest.raises(ValueError) assertions.
tests/jobs/test_job_decorator.py	Parametrize argnames tuple.
tests/host/test_network.py	Use return fixture (no teardown).
tests/host/test_manager.py	Use return fixture (no teardown).
tests/host/test_logs.py	Add match= to ValueError assertions; parametrize argnames tuple.
tests/host/test_firewall.py	Use return fixtures (no teardown).
tests/host/test_configuration.py	Replace manual try/except with pytest.raises(..., match=...); use return fixture.
tests/host/test_apparmor_control.py	Replace from pytest import raises with import pytest.
tests/homeassistant/test_core.py	Parametrize argnames tuple.
tests/hardware/test_helper.py	Replace from pytest import LogCaptureFixture with pytest.LogCaptureFixture.
tests/docker/test_monitor.py	Parametrize argnames tuple.
tests/docker/test_interface.py	Parametrize argnames tuple; reformat multi-arg parametrizations.
tests/dbus/udisks2/test_partition.py	Use return fixtures (no teardown).
tests/dbus/udisks2/test_partition_table.py	Use return fixtures (no teardown).
tests/dbus/udisks2/test_nvme_controller.py	Use return fixture (no teardown).
tests/dbus/udisks2/test_manager.py	Use return fixtures (no teardown).
tests/dbus/udisks2/test_filesystem.py	Use return fixtures (no teardown).
tests/dbus/udisks2/test_drive.py	Use return fixtures (no teardown).
tests/dbus/udisks2/test_block.py	Use return fixtures (no teardown).
tests/dbus/test_timedate.py	Use return fixture (no teardown).
tests/dbus/test_systemd.py	Use return fixture (no teardown).
tests/dbus/test_resolved.py	Use return fixture (no teardown).
tests/dbus/test_rauc.py	Use return fixture (no teardown).
tests/dbus/test_login.py	Use return fixture (no teardown).
tests/dbus/test_interface.py	Use return fixtures (no teardown).
tests/dbus/test_hostname.py	Use return fixture (no teardown).
tests/dbus/test_enum.py	Add match= to ValueError assertions.
tests/dbus/network/test_wireless.py	Use return fixture (no teardown).
tests/dbus/network/test_settings.py	Use return fixture (no teardown).
tests/dbus/network/test_network_manager.py	Use return fixture (no teardown).
tests/dbus/network/test_ip_configuration.py	Use return fixtures (no teardown).
tests/dbus/network/test_interface.py	Use return fixture (no teardown).
tests/dbus/network/test_dns.py	Use return fixture (no teardown).
tests/dbus/network/test_accesspoint.py	Use return fixture (no teardown).
tests/dbus/network/setting/test_init.py	Use return fixture; parametrize argnames tuple.
tests/dbus/agent/test_system.py	Use return fixture (no teardown).
tests/dbus/agent/test_swap.py	Use return fixture (no teardown).
tests/dbus/agent/test_datadisk.py	Use return fixture (no teardown).
tests/dbus/agent/test_cgroup.py	Use return fixture (no teardown).
tests/dbus/agent/test_apparmor.py	Use return fixture (no teardown).
tests/dbus/agent/test_agent.py	Use return fixture; parametrize argnames tuple.
tests/dbus/agent/boards/test_yellow.py	Use return fixture (no teardown).
tests/dbus/agent/boards/test_green.py	Use return fixture (no teardown).
tests/dbus/agent/boards/test_board.py	Use return fixture (no teardown).
tests/backups/test_manager.py	Parametrize argnames tuple (multiple).
tests/backups/test_backup.py	Adjust pytest.raises block contents.
tests/backups/conftest.py	Use return fixtures (no teardown).
tests/apps/test_manager.py	Use return fixture (no teardown).
tests/apps/test_app.py	Parametrize argnames tuple.
tests/api/test_os.py	Use return fixture (no teardown).
tests/api/test_mounts.py	Use return fixture (no teardown).
tests/api/test_host.py	Use return fixture (no teardown).
tests/api/test_backups.py	Parametrize argnames tuple (multiple).
tests/api/middleware/test_security.py	Use return fixtures (no teardown); parametrize argnames tuple.
tests/api/conftest.py	Use return fixture (no teardown).

Comments suppressed due to low confidence (2)

tests/conftest.py:720

• This fixture now uses return, but the signature still declares Generator[MagicMock]. Update the return type to MagicMock (or revert to yield) to keep the fixture typing consistent.

@pytest.fixture
def websession(coresys: CoreSys) -> Generator[MagicMock]:
    """Fixture for global aiohttp SessionClient.

    Also mocks Core container is_running to return True so that
    make_request doesn't bail before reaching the websession.
    """
    coresys._websession = MagicMock(spec_set=ClientSession)
    coresys.homeassistant.core.instance.is_running = AsyncMock(return_value=True)
    return coresys._websession

tests/conftest.py:730

• This fixture now uses return, but the signature still declares Generator[MockResponse]. Update the return type to MockResponse (or revert to yield) to keep the fixture typing consistent.

@pytest.fixture
def mock_update_data(websession: MagicMock) -> Generator[MockResponse]:
    """Mock updater JSON data."""
    version_data = load_fixture("version_stable.json")
    client_response = MockResponse(text=version_data)
    client_response.status = 200
    websession.get = MagicMock(return_value=client_response)
    return client_response

[Copilot]

Pull request overview

Copilot reviewed 77 out of 77 changed files in this pull request and generated no new comments.

[mdegat01]

Lots of small changes but yea I get the patterns, makes sense 👍

[mdegat01]

This one seems very opinionated by the way

Just basically says project preference for consistency as the reason. We are doing it most of the time though so I suppose that's fine. The main thing that'll get in the way is just auto-import but can just fix it.

[agners]

This one seems very opinionated by the way [PT013]

Yeah quite some of these linter rules can be categorized as opinionated style. I tend to favor consistency, and enabling these rules do that.

FWIW, Core uses the rule too.