fix: panel is hidden unexpectedly after resume from suspend or lock#2490
Open
wysha-object wants to merge 2 commits into
Open
fix: panel is hidden unexpectedly after resume from suspend or lock#2490wysha-object wants to merge 2 commits into
wysha-object wants to merge 2 commits into
Conversation
Author
|
Hi @charlesg99 , could you take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2461
Each time resuming from suspend or lock, the
enablemethod is executed, which then adds the "Dock" option switch into the disabled list, causing the original GNOME Shell dash to be hidden.By adding an additional conditional check, we can ensure that when the "Keep original GNOME Shell dash" option is enabled, the dock is not incorrectly hidden.
Additionally, I think the dock visibility could be fully controlled by the options in GNOME Settings. The "Keep original GNOME Shell dash" option and the logic for disabling the GNOME Settings Dock option should be removed.