Implement "application-counter-overrides-notifications" setting#2516
Open
diesieben07 wants to merge 1 commit into
Open
Implement "application-counter-overrides-notifications" setting#2516diesieben07 wants to merge 1 commit into
diesieben07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2515 by not summing up notification count and app provided count (
com.canonical.Unity.LauncherEntry) by default.A setting is provided to restore the original behavior. I have made the new behavior the default, because I do not think the old behavior (before this PR) is useful, it will usually just result in a badge counter that is twice as high as it should be.
I have added German localization for the new setting, as that is the only language besides English that I speak.
This is my first time working on anything related to GNOME extensions, please let me know if I have done something wrong. I have tested this locally with
make installand it worked fine.