Fixed mid-animation crash for peeks#2518
Open
zachinglis wants to merge 1 commit into
Open
Conversation
If an app icon goes away while it's mid-hover (such as moving it to a different workspace), the onComplete fires with a missing object, and bails. Chained the commands to stop it erroring. Fixes home-sweet-gnome#1712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to fix a bug I had, I discovered another. Figured I'd fix it first before I moved onto mine. (Unfortunately mine requires design decisions that I don't think is my place to do - probably a new Set or such.)
One thing; I know you use
foo = barmore style wise. But I felt this was cleaner over an if block. Can rewrite it to an if block if thatsa preference.Noticed #1712 is still occurring. So this will fix that. Lint, etc pass.