test(plugins): create the empty running path so the package.json guard is reached - #2990
Merged
bwp91 merged 1 commit intoAug 22, 2026
Merged
Conversation
…d is reached The test pointed at a directory no fixture creates, so realpath() threw ENOENT and it exercised the same branch as the neighbouring "does not exist" case. Dropping the existsSync check from getInstalledModules left every test in the file green; with the directory in place it fails exactly this one.
bwp91
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the tests I added in #2973 never reached the check it was named after.
leaves the scan alone when the running path has no package.jsonpointsrunningHomebridgeModulePathatopt-homebridge/empty, which no fixture creates, sorealpath()throws ENOENT and it lands in the same branch as thedoes not existcase below it.Creating the directory puts it on the branch its name describes. Removing the
existsSync(join(resolvedRunningPath, 'package.json'))condition fromgetInstalledModules()used to leave all 108 tests in the file green; now it fails exactly this one.No production change, and nothing to clean up: the block's
afterEachalready removesopt-homebridgeand everything under it. 108 passing, lint clean.