Skip to content

Conversation

@guanzo
Copy link

@guanzo guanzo commented Nov 12, 2022

Relevant issue: https://www.reddit.com/r/Enhancement/comments/l1boqd/comments_duplicating_in_never_ending_reddit/
Tested in browser: chrome, firefox

To reproduce:

  1. scroll to bottom of page, wait for /api/morechildren request to send
  2. scroll up until the red loading... text exits the bottom of the viewport
  3. scroll back down. A 2nd /api/morechildren request should be sent, causing duplicate comments.

Solution is to ensure that the same loader link is never clicked twice.

My implementation checks if the loader link has the loading text, if so then ignore it.

It works, but will there be any issues with translations? Like will the loading text check fail for spanish users, etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant