Fix firefox legacy favicon #5574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the legacy favicon is not displayed in Firefox.
The issue stems from Firefox’s
FaviconLoader.sys.mjsmodule, which automatically fetches favicons (favicon-16x16.png and android-icon-192x192.png). It appears to be a race condition between the browser module and the RES extension, preventing the legacy favicon from being persistently loaded.FaviconLoader.sys.mjs in action
My workaround for this: an event listener that sets the
hrefattribute of the link, forcing Firefox to use the correct favicon instead of the one fetched byFaviconLoader.sys.mjs.Relevant issues: #5551, https://www.reddit.com/r/RESissues/comments/1k3zcoh/use_legacy_favicon_only_works_sometimes_firefox/
Tested in browser: Firefox 130