fix: Find IPv6 addresses properly #1772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation incorrectly wraps IPv4 addresses in brackets when UseIPV6Identifier is true because ip.To16() returns non-nil for IPv4 addresses (as IPv4-mapped IPv6). This causes invalid URL literals like "http://[100.122.93.238]:8081". This commit extracts the IP selection logic into a testable function and adds test cases that demonstrate the bug. Co-Authored-By: Claude Opus 4.5 <[email protected]>
ip.To16() returns non-nil for both IPv4 and IPv6 addresses (IPv4 addresses are returned as IPv4-mapped IPv6). This caused IPv4 addresses to be incorrectly wrapped in brackets when UseIPV6Identifier was true, resulting in invalid URL literals like "http://[100.122.93.238]:8081". The fix uses ip.To4() == nil which correctly returns true only for actual IPv6 addresses. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
IPv6 addresses weren't being found properly, even when UseIPV6Identifier set to true. This is because the To16() call didn't return Nil when an IPv4 address was fed in.
Short description of the changes
This changes the call to use To4() and it skips it on success.
The robust test cases should help avoid a regression as well.