Skip to content

UI enhancements and Docker dependency management #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PranshuLakhotia
Copy link

This PR introduces the following improvements:

UI Enhancements:
Added a dark/light mode toggle with persistent user preferences.
Improved log controls with modern, responsive buttons for refreshing and clearing logs.
Enhanced log filtering by Session ID with dynamic highlighting and search functionality.
Updated the overall UI to be more modern and user-friendly.

Docker Improvements:
Added a requirements.txt file for flexible dependency management.
Ensured reproducibility and easier updates for Python dependencies.

WhatsApp Image 2025-02-08 at 23 02 01
WhatsApp Image 2025-02-08 at 23 02 15
WhatsApp Image 2025-02-08 at 23 41 01

@PranshuLakhotia
Copy link
Author

@gtheodoridis @m-vasiloma waiting for your heads up.
Thank You.

@glaslos glaslos requested a review from gtheodoridis February 15, 2025 19:15
@gtheodoridis
Copy link
Collaborator

  • Why do we need to expose port 5001? Is there a system relying on it?
  • Requirements.txt exists, did you mean to fix that the flask_logging_server service installs Flask directly without referencing a requirements.txt file?

Copy link
Collaborator

@gtheodoridis gtheodoridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI changes look good to me

Issue: The additional port 5001:5000 may introduce unintended exposure of the logserver service. If this is needed, we should document why. Otherwise, we should remove it.

Additionally, flask_logging_server/Dockerfile does not install dependencies from a requirements.txt file. For maintainability, we should consider adding it.

@PranshuLakhotia
Copy link
Author

@gtheodoridis yes sir the port change is not needed actually it was just used to run on my local machine will update it soon and I will add a req. txt filr for flask_logging_server/Dockerfile.
Will raise a PR within an hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants