feat: add fullstack short link feature#1958
Open
likuang97 wants to merge 1 commit intohongshancapital:masterfrom
Open
feat: add fullstack short link feature#1958likuang97 wants to merge 1 commit intohongshancapital:masterfrom
likuang97 wants to merge 1 commit intohongshancapital:masterfrom
Conversation
YuBoxiang
reviewed
Jul 27, 2023
| } | ||
| const id = await sql.begin(async (sql) => { | ||
| const results = | ||
| await sql`select id from short_links where url = ${url} limit 1`; |
Author
There was a problem hiding this comment.
// CREATE TABLE short_links (
// id bigserial PRIMARY KEY,
// url text,
// created_at timestamp DEFAULT current_timestamp
// );
// CREATE INDEX url_index ON short_links (url);
url 字段建了索引的
Author
There was a problem hiding this comment.
CREATE INDEX url_index ON short_links (url);
Collaborator
There was a problem hiding this comment.
感觉加个 短 url column,索引建在 short url 上,可以节省点索引空间?
Author
There was a problem hiding this comment.
嗯,postgres 默认用的是b-tree 索引,可以换成 hash 索引来节省索引空间。
CREATE INDEX index_name
ON short_links USING HASH (url);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.