build: remove esbuild and build as esm format #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ryoppippi This is awesome PR. Looks good. This will reduce the bin size, and that change will big impact for the user. So, I'll release a new minor version after merging. Thanks! |
|
@yusukebe Thank you for reviewing! I believe that libraries like exca and commander can also be replaced by more lightweight ones, and I will send PRs about them in my spare time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for creating hono as always!!
In this PR,
As a result, build time is slightly faster (on my m3 Pro macbook pro 230ms -> 110ms), and the bundle size is 520kb -> 460kb!