Skip to content

chore(april-fool): change hono is cool to hono is hot #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 1, 2025

Conversation

EdamAme-x
Copy link
Contributor

Hono should be hot

@EdamAme-x EdamAme-x marked this pull request as draft March 31, 2025 15:24
@usualoma
Copy link
Member

LGTM! Leaving aside the question of whether it can be merged or not, I'm glad you made this pull request.

@yusukebe
Copy link
Member

yusukebe commented Apr 1, 2025

@EdamAme-x

Love this. Please make it ready, and I will merge it.

@EdamAme-x EdamAme-x marked this pull request as ready for review April 1, 2025 05:53
@EdamAme-x
Copy link
Contributor Author

lol

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (0bb821a) to head (896b128).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
+ Coverage   91.28%   91.32%   +0.03%     
==========================================
  Files         168      168              
  Lines       10768    10684      -84     
  Branches     3070     3062       -8     
==========================================
- Hits         9830     9757      -73     
+ Misses        937      926      -11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe changed the title april-fool: change hono is cool to hono is hot chore(april-fool): change hono is cool to hono is hot Apr 1, 2025
@yusukebe
Copy link
Member

yusukebe commented Apr 1, 2025

@EdamAme-x Thanks!

Let's go with this.

@yusukebe yusukebe merged commit 882e75a into honojs:main Apr 1, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants