Skip to content

feat(mime): support webmanifest #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sushichan044
Copy link
Contributor

@sushichan044 sushichan044 commented Apr 16, 2025

ref: #3736 (comment)

The web manifest is an important file in explaining information to browsers when installing a website as a PWA.

The specification recommends that this file should be associated with application/manifest+json or some other JSON-like MIME type, but hono does not currently support this.
This PR will resolve it.

[note]
I think no special action is needed for @hono/noder-server as hono is marked as peerDependencies in it.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (4b20956) to head (4fee360).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4085    +/-   ##
========================================
  Coverage   91.29%   91.29%            
========================================
  Files         168      168            
  Lines       10766    10767     +1     
  Branches     3177     3045   -132     
========================================
+ Hits         9829     9830     +1     
  Misses        936      936            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hey @sushichan044

Looks good! This is a feat PR, but the update is slight. So, I may merge this and include this change as a patch release. I'll decide and merge. Thanks!

@yusukebe yusukebe added the v4.8 label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants