feat(logger): support for NO_COLOR on cloudflare workers
#4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4094 +/- ##
==========================================
- Coverage 91.47% 91.36% -0.12%
==========================================
Files 168 168
Lines 10791 10753 -38
Branches 3088 3107 +19
==========================================
- Hits 9871 9824 -47
- Misses 919 928 +9
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I also have another plan, #4095. |
|
If it's ready to review, please ping me:) |
ryuapp
force-pushed
the
support-for-no_color-on-cloudflare-workers
branch
from
9d25f4c to
d036a85
Compare
Old Cloudflare workers are missing import('cloudflare:workers')
|
@yusukebe This is now ready for review. |
yusukebe
reviewed
Apr 26, 2025
ryuapp
force-pushed
the
support-for-no_color-on-cloudflare-workers
branch
from
ab269b1 to
4a2e1c1
Compare
|
Thanks @ryuapp ! I'll merge this later and include the next minor release (maybe shipped soon). |
4 tasks
…r-on-cloudflare-workers
ysm-dev
reviewed
Jun 18, 2025
| navigator !== undefined && navigator.userAgent === 'Cloudflare-Workers' | ||
| ? // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| 'NO_COLOR' in ((await import('cloudflare:workers')).env ?? {}) // ?? {} is for backward compat |
There was a problem hiding this comment.
There was a problem hiding this comment.
@ysm-dev Can you create an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3751
Note
Currently,
process.envis available on Cloudflare Workers withnodejs_compatflag, so there may not be a need to support it.https://developers.cloudflare.com/workers/runtime-apis/nodejs/process/#processenv
Logger now uses
getColorEnabledAsync()to support retrieving cloudflare env. Since we couldn't support this without dynamic import now, I created a newgetColorEnabled()that is asynchronous.getColorEnabled()is maintained for backwards compatibility forshowRoute().The cost of dynamic imports has not been investigated, so it may be necessary to optimize it with following PR:
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code