Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ArkType errors with Hono 4 #1006

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: ArkType errors with Hono 4 #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cff8c92
fix: ArkType errors with Hono 4
FLchs Mar 5, 2025
03bd15d
feat: use summary from ArkType validation as errors
FLchs Mar 5, 2025
cd6111e
chore: update depdencies
FLchs Mar 5, 2025
7c39c1c
test: improve ArkType test
FLchs Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/arktype-validator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"hono": "*"
},
"devDependencies": {
"arktype": "^2.0.0-dev.14",
"hono": "^3.11.7",
"arktype": "^2.1.2",
"hono": "^4.7.2",
"tsup": "^8.0.1",
"vitest": "^1.0.4"
}
Expand Down
7 changes: 6 additions & 1 deletion packages/arktype-validator/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,21 @@ describe('Basic', () => {
age: '20',
}),
method: 'POST',
headers: {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifying the content type made the test successful even with valid body...

'Content-Type': 'application/json',
},
})
const res = await app.request(req)
expect(res).not.toBeNull()
expect(res.status).toBe(400)
const data = (await res.json()) as { success: boolean }
const data = (await res.json()) as { success: boolean, errors: string }
expect(data['success']).toBe(false)
expect(data.errors).toEqual("age must be a number (was a string)")
})
})

describe('With Hook', () => {

const app = new Hono()

const schema = type({
Expand Down
2 changes: 1 addition & 1 deletion packages/arktype-validator/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const arktypeValidator = <
return c.json(
{
success: false,
errors: out,
errors: out.summary,
},
400
)
Expand Down
57 changes: 32 additions & 25 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,26 +43,26 @@ __metadata:
languageName: node
linkType: hard

"@ark/schema@npm:0.44.0":
version: 0.44.0
resolution: "@ark/schema@npm:0.44.0"
dependencies:
"@ark/util": "npm:0.44.0"
checksum: 3f7f9d5a0077f3c042d0c0f84a0dcf3135252afff330c54589db7745e9014c2a4d9abb3fa4ea13fcbd74a2af7b35a5fe780a1f2eba0781689a9076e7b5b8c723
languageName: node
linkType: hard

"@ark/util@npm:0.26.0":
version: 0.26.0
resolution: "@ark/util@npm:0.26.0"
checksum: 60c54dca4556b1ccb6f4a3dc1e28beb09219ee3f01124916550c993f0508ac2142c9c967992ee16a71334e849c214234e6c3e4c2271dc104a893068a9cc33afc
languageName: node
linkType: hard

"@arktype/schema@npm:0.1.4-cjs":
version: 0.1.4-cjs
resolution: "@arktype/schema@npm:0.1.4-cjs"
dependencies:
"@arktype/util": "npm:0.0.41-cjs"
checksum: dd83edcbd29ab8b1faf4c8aee3d03b7d75a4cc7848c44cffd0580b89cfa0cabd280916fcd94317b89fc9d730a0fb6c9e7f53db9088788f54dd9077d5479c1b2f
languageName: node
linkType: hard

"@arktype/util@npm:0.0.41-cjs":
version: 0.0.41-cjs
resolution: "@arktype/util@npm:0.0.41-cjs"
checksum: 77013353924d4f1d81eacc782b7bf07ac21fd5e96368505e05f75dfc822933cb3fc65ba055cc60105f5a86f89c9f4d60aa8be8f0942ebee93f0165cbe4e4b2b9
"@ark/util@npm:0.44.0":
version: 0.44.0
resolution: "@ark/util@npm:0.44.0"
checksum: 4e37b0568280bd778eb30ee84f56d1cbe57c09cf82d3915d20a95f7aa9522c40742c6715107b04b92c4b113b12bf1d0f40c920837eae69792a647ac44bfcde3b
languageName: node
linkType: hard

Expand Down Expand Up @@ -2372,8 +2372,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "@hono/arktype-validator@workspace:packages/arktype-validator"
dependencies:
arktype: "npm:^2.0.0-dev.14"
hono: "npm:^3.11.7"
arktype: "npm:^2.1.2"
hono: "npm:^4.7.2"
tsup: "npm:^8.0.1"
vitest: "npm:^1.0.4"
peerDependencies:
Expand Down Expand Up @@ -5972,16 +5972,6 @@ __metadata:
languageName: node
linkType: hard

"arktype@npm:^2.0.0-dev.14":
version: 2.0.0-dev.12-cjs
resolution: "arktype@npm:2.0.0-dev.12-cjs"
dependencies:
"@arktype/schema": "npm:0.1.4-cjs"
"@arktype/util": "npm:0.0.41-cjs"
checksum: b0e7fc182bb6d4d0d4e125744a5b8233295d2ca30715f1bafdd158d37ed8abffafe0f5ef28ff8f99f82ffb1b8d1f36fcc282035c4ef4b909a748c1d520044afc
languageName: node
linkType: hard

"arktype@npm:^2.0.0-rc.26":
version: 2.0.0-rc.26
resolution: "arktype@npm:2.0.0-rc.26"
Expand All @@ -5992,6 +5982,16 @@ __metadata:
languageName: node
linkType: hard

"arktype@npm:^2.1.2":
version: 2.1.5
resolution: "arktype@npm:2.1.5"
dependencies:
"@ark/schema": "npm:0.44.0"
"@ark/util": "npm:0.44.0"
checksum: 743ef0459f2572da9b2177b92fff113ee0ffc7a247e1ed425309f893b668306f75e3470a5490cd2b41588e3ecc9de12934dd92b08098d47e8f6685db6e7538da
languageName: node
linkType: hard

"array-buffer-byte-length@npm:^1.0.0":
version: 1.0.0
resolution: "array-buffer-byte-length@npm:1.0.0"
Expand Down Expand Up @@ -11136,6 +11136,13 @@ __metadata:
languageName: node
linkType: hard

"hono@npm:^4.7.2":
version: 4.7.4
resolution: "hono@npm:4.7.4"
checksum: b189c5b75527a0b2c6669a8b2d46a2c522c9f429c08da801373b13d25b476f20e639f667a9dac2fe42074e9b6f851d542d28026f158c5728b20034b9b0e3e738
languageName: node
linkType: hard

"hosted-git-info@npm:^2.1.4":
version: 2.8.9
resolution: "hosted-git-info@npm:2.8.9"
Expand Down