Skip to content

Comments

test(workspace): upgrade to vitest v3#1009

Merged
yusukebe merged 7 commits intohonojs:mainfrom
BarryThePenguin:refactor/vitest-workspace
Mar 12, 2025
Merged

test(workspace): upgrade to vitest v3#1009
yusukebe merged 7 commits intohonojs:mainfrom
BarryThePenguin:refactor/vitest-workspace

Conversation

@BarryThePenguin
Copy link
Contributor

Fixes #1007

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: 1c866da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yusukebe
Copy link
Member

Bun Transpiler

Why the Bun Transpiler test fails due to the following issue:

oven-sh/bun#14978

For example, if you have this code:

const transpiler = new Bun.Transpiler({
  loader: 'tsx'
})

const code = `const hello = <h1>hello world</h1>`

const result = transpiler.transformSync(code)
console.log(result)

The result is:

$ bun run transpiler.ts
const hello = jsxDEV_7x81h0kn("h1", {
  children: "hello world"
}, undefined, false, undefined, this);

This is Bun's side matter, and I think it will be fixed. So, we can wait for it. Or we can fix Bun's version, which is currently in our CI.

@BarryThePenguin What do you think of it?

@yusukebe
Copy link
Member

Weird! All fests fail! The yarn.lock was not changed when I ran yarn install on my machine. Hmm.

@NEKOYASAN
Copy link

NEKOYASAN commented Mar 11, 2025

yarn install after rebase or merge Base branch commits will solve the problem.

This happens because GitHub Action uses the latest base branch merged into this branch.

(from checkout step)

HEAD is now at 491a833 Merge 71a0520f4db8d8d443811f3831ea730ac438204a into 44efa2a048a68a587fed799a4a6b10dc9c7b343e

@yusukebe
Copy link
Member

@NEKOYASAN

You are super! It was fixed. Thank you so much!

@BarryThePenguin
Copy link
Contributor Author

Let's fix Bun's version to 1.1.32, and create an issue to revisit it once the issue is fixed in Bun

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@BarryThePenguin

Thanks! Let's go!

@yusukebe yusukebe merged commit 4d67af1 into honojs:main Mar 12, 2025
31 checks passed
@BarryThePenguin BarryThePenguin deleted the refactor/vitest-workspace branch March 12, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vitest.workspace

3 participants