Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 78.10% 78.10%
=======================================
Files 74 74
Lines 2128 2128
Branches 553 553
=======================================
Hits 1662 1662
Misses 390 390
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BarryThePenguin
commented
Mar 18, 2025
| @@ -1,5 +1,7 @@ | |||
| # Ajv validator middleware for Hono | |||
|
|
|||
| [](https://codecov.io/github/honojs/middleware) | |||
Contributor
Author
There was a problem hiding this comment.
Each badge should include a flag and only show the coverage for that flag
Comment on lines
+13
to
+15
| import { type JSONSchemaType } from 'ajv' | ||
| import { ajvValidator } from '@hono/ajv-validator' | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Looks like prettier and vscode decided to format code blocks on save.. happy to revert this if it's an issue
BarryThePenguin
commented
Mar 18, 2025
| @@ -1,13 +1,13 @@ | |||
| name: ci-cabin | |||
| name: ci-casbin | |||
Contributor
Author
There was a problem hiding this comment.
Looks like this spelling mistake has existed for a while..
yusukebe
approved these changes
Mar 19, 2025
Comment on lines
+13
to
+15
| import { type JSONSchemaType } from 'ajv' | ||
| import { ajvValidator } from '@hono/ajv-validator' | ||
|
|
Member
|
Good idea! Let's go with this. |
TimBarley
pushed a commit
to TimBarley/honojs-middleware
that referenced
this pull request
Apr 9, 2025
* chore: add coverage badges * ci(casbin): fix spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a coverage badge to each readme. This is also a good opportunity to make sure everything is working correctly 👀
With
oidc-authfor example