Skip to content

fix(node-ws): adapter shouldn't send buffer as a event #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

nakasyou
Copy link
Contributor

@nakasyou nakasyou commented Apr 1, 2025

Resolves #1077 (review) and refers honojs/hono#4036.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 1c5c991

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/node-ws Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (b18f243) to head (1c5c991).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/node-ws/src/index.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   79.52%   79.50%   -0.02%     
==========================================
  Files          77       77              
  Lines        2276     2279       +3     
  Branches      574      577       +3     
==========================================
+ Hits         1810     1812       +2     
- Misses        390      391       +1     
  Partials       76       76              
Flag Coverage Δ
cloudflare-access 2.72% <0.00%> (-0.01%) ⬇️
node-ws 2.36% <30.76%> (+0.08%) ⬆️
oauth-providers 26.28% <61.53%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Apr 1, 2025

@nakasyou

Thank you! I'll merge this.

@yusukebe yusukebe merged commit 519404a into honojs:main Apr 1, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 1, 2025
TimBarley pushed a commit to TimBarley/honojs-middleware that referenced this pull request Apr 9, 2025
* fix(node-ws): adapter shouldn't send buffer as a event

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants