Skip to content

fix(oauth-providers): Update twitter authorization url #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

liquidleif
Copy link
Contributor

The twitter authorization URL didn't work for me. Patched it locally to x.com/[...] and it works for me.

The twitter authorization URL is outdated.
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (e8512f0) to head (3bd60f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   79.50%   79.50%           
=======================================
  Files          77       77           
  Lines        2279     2279           
  Branches      577      577           
=======================================
  Hits         1812     1812           
  Misses        391      391           
  Partials       76       76           
Flag Coverage Δ
oauth-providers 26.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe changed the title Update twitter authorization url fix(oauth-providers): Update twitter authorization url Apr 3, 2025
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 3bd60f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/oauth-providers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Apr 3, 2025

@liquidleif

Thanks! Looks good.

@yusukebe yusukebe merged commit 091b182 into honojs:main Apr 3, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
yusukebe pushed a commit to BarryThePenguin/middleware that referenced this pull request Apr 7, 2025
Closes honojs#1100

* Update twitter authorization url

The twitter authorization URL is outdated.

* add a changeset
TimBarley pushed a commit to TimBarley/honojs-middleware that referenced this pull request Apr 9, 2025
Closes honojs#1100

* Update twitter authorization url

The twitter authorization URL is outdated.

* add a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants