Skip to content

fix(zod-openapi): infer Env correctly if the middleware is [] #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Apr 7, 2025

Fixes the issue commented on #1102 (comment)

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: 5ad14c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (e8512f0) to head (5ad14c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   79.50%   79.50%           
=======================================
  Files          77       77           
  Lines        2279     2279           
  Branches      577      577           
=======================================
  Hits         1812     1812           
  Misses        391      391           
  Partials       76       76           
Flag Coverage Δ
zod-openapi 5.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe merged commit 448a8fc into main Apr 7, 2025
1 check passed
@yusukebe yusukebe deleted the fix/zod-openapi-middleware-empty-infer branch April 7, 2025 09:41
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
yusukebe added a commit to BarryThePenguin/middleware that referenced this pull request Apr 7, 2025
…js#1106)

* fix(zod-openapi): infer Env correctly if the middleware is `[]`

* add changeset
TimBarley pushed a commit to TimBarley/honojs-middleware that referenced this pull request Apr 9, 2025
…js#1106)

* fix(zod-openapi): infer Env correctly if the middleware is `[]`

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants