Skip to content

chore(conform-validator): Change conform valibot adapter to official library #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

chimame
Copy link
Contributor

@chimame chimame commented Apr 9, 2025

Overview

The form library Conform now officially supports valibots, so the description has been revised.

Until now, Conform required the use of a library called conform-to-valibot to use valibot, but this Pull Request has made it officially supported.

So I changed the library listed in the test code and README. Changing the library does not change the API.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

Copy link

changeset-bot bot commented Apr 9, 2025

⚠️ No Changeset found

Latest commit: 9053ea5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (1fd8ebf) to head (9053ea5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   79.50%   79.50%           
=======================================
  Files          77       77           
  Lines        2279     2279           
  Branches      577      577           
=======================================
  Hits         1812     1812           
  Misses        391      391           
  Partials       76       76           
Flag Coverage Δ
conform-validator 1.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe changed the title chore: Change conform valibot adapter to official library chore(conform-validator): Change conform valibot adapter to official library Apr 9, 2025
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Apr 9, 2025

Until now, Conform required the use of a library called conform-to-valibot to use valibot, but this Pull Request has made it officially supported.

It's great to hear that! Looks good. Thank you.

@yusukebe yusukebe merged commit 26d0efb into honojs:main Apr 9, 2025
1 check passed
@chimame chimame deleted the change-valibot-adapter-of-conform branch April 9, 2025 12:31
TimBarley pushed a commit to TimBarley/honojs-middleware that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants