-
Notifications
You must be signed in to change notification settings - Fork 221
feat(oidc-auth): support empty OIDC client secret #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 215f376 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Can you run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
- Coverage 79.53% 79.50% -0.03%
==========================================
Files 77 77
Lines 2282 2284 +2
Branches 578 580 +2
==========================================
+ Hits 1815 1816 +1
- Misses 391 392 +1
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @hnw! Can you review this? We should add tests, but if it's difficult, it's okay not to. |
f9a5929
to
7eee61b
Compare
I ran yarn changeset, hope I did this right |
7eee61b
to
215f376
Compare
all good now? |
ping to get this landed |
Can you write a proper test? |
Hi,
I found that this library does not work with https://lastlogin.net/developers/
Would a change like this be ok?