Skip to content

feat(oidc-auth): support empty OIDC client secret #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tarasglek
Copy link

Hi,
I found that this library does not work with https://lastlogin.net/developers/

Would a change like this be ok?

Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: 215f376

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/oidc-auth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe yusukebe changed the title support empty OIDC client secret feat(oidc-auth): support empty OIDC client secret Apr 17, 2025
@yusukebe
Copy link
Member

@tarasglek

Can you run yarn changeset on the top of the project and push the generated file?

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (6c36f52) to head (215f376).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/oidc-auth/src/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   79.53%   79.50%   -0.03%     
==========================================
  Files          77       77              
  Lines        2282     2284       +2     
  Branches      578      580       +2     
==========================================
+ Hits         1815     1816       +1     
- Misses        391      392       +1     
  Partials       76       76              
Flag Coverage Δ
oidc-auth 9.98% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe
Copy link
Member

yusukebe commented Apr 17, 2025

Hi @hnw! Can you review this? We should add tests, but if it's difficult, it's okay not to.

@tarasglek tarasglek force-pushed the taras/lastlogin branch 3 times, most recently from f9a5929 to 7eee61b Compare April 17, 2025 06:36
@tarasglek
Copy link
Author

I ran yarn changeset, hope I did this right

@tarasglek
Copy link
Author

all good now?

@tarasglek
Copy link
Author

ping to get this landed

@yusukebe
Copy link
Member

@tarasglek

Can you write a proper test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants