-
Notifications
You must be signed in to change notification settings - Fork 252
hono/mcp v0.2 #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hono/mcp v0.2 #1318
Conversation
🦋 Changeset detectedLatest commit: 1c773d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for this amazing middleware contribution! I've been using your implementation and found I needed the I've created a separate PR that focuses solely on the Transport implementation from #1318. If you find it useful, please feel free to incorporate these changes back into #1318. As a suggestion, since the auth implementation appears to be ongoing, would it make sense to split the streamableHTTPTransport into a separate PR #1392 to move forward incrementally? Thank you again for laying the groundwork with your original implementation! |
Thanks @himorishige, I just completed the auth changes. Need to write the tests but rest all seems good. (Thanks you for pushing me to complete it) Are there any extra changes you have done in your PR? If yes then kindly create the PR for this branch instead of hono and I can review and merge it. |
As requested, I’ve opened a dedicated PR against your branch: MathurAditya724/hono‑middleware #3. This PR extracts and enhances the StreamableHTTPTransport implementation from your draft PR #1318. It adds MCP HTTP streaming transport support along with queue management, message size limits, backpressure handling and other improvements, while keeping your original architecture and test suite. All tests are passing, so if you find these changes useful, please feel free to merge or cherry‑pick them into your auth PR when convenient. If I’ve misunderstood the correct target or opened the PR in the wrong place, please let me know and I’ll fix it — apologies in advance. Thank you again for your excellent groundwork on the transport and auth implementation. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
+ Coverage 48.52% 49.81% +1.29%
==========================================
Files 103 113 +10
Lines 3386 3792 +406
Branches 867 996 +129
==========================================
+ Hits 1643 1889 +246
- Misses 1413 1553 +140
- Partials 330 350 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the README to describe the new feature and add a changeset?
I am thinking of updating the docs with more examples and also add things like config for different auth providers, making it easy to integrate them with |
@yusukebe should we merge this and I'll add the examples later, or do you want me to add the examples first? |
Hi @MathurAditya724 ! I think merging this first and adding the examples later is good. I'll review this later! |
@hono/ajv-validator
@hono/arktype-validator
@hono/auth-js
@hono/bun-compress
@hono/bun-transpiler
@hono/casbin
@hono/class-validator
@hono/clerk-auth
@hono/cloudflare-access
@hono/conform-validator
@hono/effect-validator
@hono/esbuild-transpiler
@hono/eslint-config
@hono/event-emitter
@hono/firebase-auth
@hono/graphql-server
@hono/hello
@hono/mcp
@hono/medley-router
@hono/node-ws
@hono/oauth-providers
@hono/oidc-auth
@hono/otel
@hono/prometheus
@hono/qwik-city
@hono/react-compat
@hono/react-renderer
@hono/sentry
@hono/session
@hono/ssg-plugins-essential
@hono/standard-validator
@hono/stytch-auth
@hono/swagger-editor
@hono/swagger-ui
@hono/trpc-server
@hono/tsyringe
@hono/typebox-validator
@hono/typia-validator
@hono/ua-blocker
@hono/valibot-validator
@hono/zod-openapi
@hono/zod-validator
commit: |
I told you you didn't have to add examples first, but can you add them now? Sorry! I've tried the SSE feature of this branch, but it does not work as I expected. So, I would like to know an example. |
Yup already working on them, will ping you once completed |
@MathurAditya724 Hi Aditya! How is working on creating examples? |
Sorry for the delay on this, got busy with work. Will finish this by tomorrow |
@MathurAditya724 No problem! |
Hey @MathurAditya724 !
What's going on with this? |
Resolves #1259
StreamableHTTPTransport
class with tests