Skip to content

Conversation

@wobsoriano
Copy link
Contributor

@wobsoriano wobsoriano commented Dec 26, 2025

The author should do the following, if applicable

Adds machine authentication support. See changeset file for more info.

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2025

🦋 Changeset detected

Latest commit: 36e4ea0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/clerk-auth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @wobsoriano

If it's ready, please ping me!

@wobsoriano wobsoriano marked this pull request as ready for review January 13, 2026 00:10
@yusukebe
Copy link
Member

@wobsoriano

Do you know why the tests fail?

@wobsoriano
Copy link
Contributor Author

@wobsoriano

Do you know why the tests fail?

Updated the tests!

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.11%. Comparing base (f8329ce) to head (36e4ea0).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1664   +/-   ##
=======================================
  Coverage   92.10%   92.11%           
=======================================
  Files         111      111           
  Lines        3674     3676    +2     
  Branches      958      958           
=======================================
+ Hits         3384     3386    +2     
  Misses        255      255           
  Partials       35       35           
Flag Coverage Δ
clerk-auth 89.28% <100.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe
Copy link
Member

@wobsoriano Nice! Plus, is it a good idea to update the README?

@wobsoriano
Copy link
Contributor Author

@yusukebe sure, updated

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@wobsoriano

Thank you! I'll merge and release a new version.

@yusukebe yusukebe merged commit 293e989 into honojs:main Jan 16, 2026
92 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants