-
Notifications
You must be signed in to change notification settings - Fork 278
feat(clerk): Add machine auth support #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 36e4ea0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c8e00a0 to
fdab87d
Compare
|
Hi @wobsoriano If it's ready, please ping me! |
56b8be4 to
3e091fc
Compare
|
Do you know why the tests fail? |
Updated the tests! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 92.10% 92.11%
=======================================
Files 111 111
Lines 3674 3676 +2
Branches 958 958
=======================================
+ Hits 3384 3386 +2
Misses 255 255
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@wobsoriano Nice! Plus, is it a good idea to update the |
|
@yusukebe sure, updated |
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thank you! I'll merge and release a new version. |
The author should do the following, if applicable
Adds machine authentication support. See changeset file for more info.
yarn changesetat the top of this repo and push the changeset