chore(turbo): more build caching#1667
Conversation
|
| - run: yarn lint:fix --cache-strategy content | ||
| - run: yarn format:fix | ||
| - run: yarn lint:fix |
There was a problem hiding this comment.
Reorder the fix commands so that prettier will format fixes from eslint
| - run: yarn workspace @hono/bun-transpiler build | ||
| - run: yarn workspace @hono/bun-transpiler typecheck | ||
| - run: yarn eslint packages/bun-transpiler | ||
| - run: yarn prettier --check . !packages packages/bun-transpiler |
There was a problem hiding this comment.
Use turbo to run the build command so the build cache is used
Also removes the eslint and prettier checks as they are handled by the build job in ci.yml
| node-version-file: .tool-versions | ||
| - run: yarn workspaces focus hono-middleware @hono/${{ matrix.package }} | ||
| - run: yarn workspaces foreach --topological --recursive --from @hono/${{ matrix.package }} run build | ||
| - run: yarn turbo --filter @hono/${{ matrix.package }} build |
There was a problem hiding this comment.
Use turbo to run the build command so the build cache is used
| - run: yarn | ||
| - run: yarn typecheck | ||
| - run: yarn lint | ||
| - run: yarn lint --cache-strategy content |
There was a problem hiding this comment.
Use content as the --cache-strategy in CI
| node-version-file: .tool-versions | ||
| - run: yarn workspaces focus hono-middleware @hono/${{ matrix.package }} | ||
| - run: yarn workspaces foreach --topological --recursive --from @hono/${{ matrix.package }} run build | ||
| - run: yarn turbo --filter @hono/${{ matrix.package }} build |
There was a problem hiding this comment.
Use turbo to run the build command so the build cache is used
| "build": { | ||
| "dependsOn": ["^build"], | ||
| "outputs": ["dist/**"] | ||
| }, |
There was a problem hiding this comment.
Adding the build command as a task so turbo can cache the build output, eg; the dist directory when running tsdown
BarryThePenguin
force-pushed
the
chore/ci-build-cache
branch
from
9206322 to
a1ffd50
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 111 111
Lines 3661 3661
Branches 967 956 -11
=======================================
Hits 3377 3377
Misses 250 250
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| - name: Build | ||
| run: yarn build | ||
| run: yarn turbo build |
There was a problem hiding this comment.
Use turbo to run the build command during a release
BarryThePenguin
force-pushed
the
chore/ci-build-cache
branch
2 times, most recently
from
25f9478 to
a04eaa8
Compare
BarryThePenguin
force-pushed
the
chore/ci-build-cache
branch
from
a04eaa8 to
a216d15
Compare
BarryThePenguin
force-pushed
the
chore/ci-build-cache
branch
from
a216d15 to
3166b3a
Compare
|
Thank you! I'm interested to see the effects. |
Based on my testing the |
2 participants
Use turbo cache when building packages