chore(typescript): add @tsconfig/strictest#1679
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 111 111
Lines 3661 3661
Branches 956 956
=======================================
Hits 3377 3377
Misses 250 250
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BarryThePenguin
force-pushed
the
chore/typescript/tsconfig-strictest
branch
2 times, most recently
from
6f312c2 to
bad8dbf
Compare
| { | ||
| "extends": "../../tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "noUnusedLocals": false, |
There was a problem hiding this comment.
Tests often use type assertions like..
type verify = Expect<Equal<Expected, Actual>>..which leaves a lot of unused declarations laying around.
One day I'd like to replace these with expectTypeOf assertions
There was a problem hiding this comment.
Ah, I see. I also tried to replace these with Vitest's, but gave up 🙃
| "strict": true, | ||
| "skipLibCheck": true, | ||
| "noUnusedLocals": false, | ||
| "noUnusedParameters": true, |
There was a problem hiding this comment.
Safe to remove as these are the default values provided by @tsconfig/strictest
| { "path": "packages/session" }, | ||
| { "path": "packages/ssg-plugins-essential" }, | ||
| { "path": "packages/standard-validator" }, | ||
| { "path": "packages/stytch-auth"}, |
There was a problem hiding this comment.
Looks like this was missing 👀
BarryThePenguin
force-pushed
the
chore/typescript/tsconfig-strictest
branch
from
bad8dbf to
43d7790
Compare
BarryThePenguin
force-pushed
the
chore/typescript/tsconfig-strictest
branch
from
4fe217a to
76d9bd5
Compare
| { | ||
| "extends": "../../tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "noUnusedLocals": false, |
There was a problem hiding this comment.
Ah, I see. I also tried to replace these with Vitest's, but gave up 🙃
|
Thank you for editing a bunch of files. Thanks! |
2 participants
@tsconfig/strictesttotsconfig.base.jsoncompilerOptionsfor each package that isn't compatible with@tsconfig/strictest