Skip to content

Conversation

@BarryThePenguin
Copy link
Contributor

Moving @types/* dependencies around and cleaning up some type assertions

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: 69dcb46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines -45 to -47
"@types/bun": "^1.0.0",
"@types/node": "^25.0.3",
"@types/ws": "^8.18.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why exactly.. but in #1077 and #1098 I moved these packages to the monorepo root.

I think it may have been related to tsup config needing to resolve types relative to the root? But we don't have that problem anymore..

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.02%. Comparing base (03a28c5) to head (69dcb46).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   92.19%   93.02%   +0.82%     
==========================================
  Files         111      112       +1     
  Lines        3664     3712      +48     
  Branches      958      944      -14     
==========================================
+ Hits         3378     3453      +75     
+ Misses        251      231      -20     
+ Partials       35       28       -7     
Flag Coverage Δ
bun-compress 95.65% <100.00%> (+76.73%) ⬆️
bun-transpiler 97.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


// eslint-disable-next-line @typescript-eslint/no-explicit-any
const decompressedResponse = new Response(decompressedReadableStream as any)
const decompressedResponse = new Response(decompressedReadableStream)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more type assertion ✨

@BarryThePenguin BarryThePenguin force-pushed the refactor/type-definitions branch from 586866d to 053462d Compare January 7, 2026 10:21
@BarryThePenguin BarryThePenguin force-pushed the refactor/type-definitions branch from cc4289f to 69dcb46 Compare January 7, 2026 10:53
import * as exec from '@actions/exec'

const exclude = new Set(['@hono/bun-transpiler'])
const exclude = new Set(['@hono/bun-compiler', '@hono/bun-transpiler'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the @hono/bun-compiler is a typo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants