-
Notifications
You must be signed in to change notification settings - Fork 278
refactor(types): move @types/* dependencies into individual workspaces
#1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(types): move @types/* dependencies into individual workspaces
#1688
Conversation
|
| "@types/bun": "^1.0.0", | ||
| "@types/node": "^25.0.3", | ||
| "@types/ws": "^8.18.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
==========================================
+ Coverage 92.19% 93.02% +0.82%
==========================================
Files 111 112 +1
Lines 3664 3712 +48
Branches 958 944 -14
==========================================
+ Hits 3378 3453 +75
+ Misses 251 231 -20
+ Partials 35 28 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const decompressedResponse = new Response(decompressedReadableStream as any) | ||
| const decompressedResponse = new Response(decompressedReadableStream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more type assertion ✨
586866d to
053462d
Compare
cc4289f to
69dcb46
Compare
| import * as exec from '@actions/exec' | ||
|
|
||
| const exclude = new Set(['@hono/bun-transpiler']) | ||
| const exclude = new Set(['@hono/bun-compiler', '@hono/bun-transpiler']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the @hono/bun-compiler is a typo?
Moving
@types/*dependencies around and cleaning up some type assertions