Skip to content

Conversation

@maemaemae3
Copy link
Contributor

Summary

Changes

  • Set third arguments of verify()
  • Added a configuration option OIDC_JWT_ALG

Testing

  • Tested case of environment value set
    • Cases that alg not set is covered with Hono side
  • Verified no impact on authentication flow.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

🦋 Changeset detected

Latest commit: 642a1ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/oidc-auth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.11%. Comparing base (16a83af) to head (642a1ee).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1705   +/-   ##
=======================================
  Coverage   92.10%   92.11%           
=======================================
  Files         111      111           
  Lines        3674     3676    +2     
  Branches      958      960    +2     
=======================================
+ Hits         3384     3386    +2     
  Misses        255      255           
  Partials       35       35           
Flag Coverage Δ
oidc-auth 96.47% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@maemaemae3

Thank you for handling it. Looks good. Merging.

@yusukebe yusukebe merged commit 8831ae1 into honojs:main Jan 16, 2026
92 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants