-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for refresh tokens to be used via access_type "offline" in Issue/#619 #634
base: main
Are you sure you want to change the base?
Conversation
I also don't really understand why it had my other pull requests in the commit logs... No changes for those files are actually in this pull request |
Closes #619 |
Hi @aaronware Thanks for the PR. I think it would be fine if you tested it with the @monoald Do you have any thoughts on this? |
Hi! We are also interested in this behaviour to configure long-running sessions (eg. polling GMail on behalf of a user). Right now the flow does not expose the refresh token (although it is received), but could very easily when correctly configured with prompt: "consent" and access_type: "offline". It is hard to monkey patch at this time as this is internal to AuthFlow. I don't know if this PR is still under consideration or if I should open a new one to cover this use case. |
Hi @Titou325 This PR is not progressing, so creating a new PR is okay. If so, I will review it. It would be better if you added proper tests there. |
I might need some support here as I wasn't able to figure out the most efficient way to test my changes based on how this all works within a worker? Any shove in the right direction would be greatly appreciated for proper testing.