Don't hide the underlying type #274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the hiding of the underlying type and its methods. A
use case would be to access the methods of `soap.XSDDateTime`.
Consider the following code:
```
type StartDate soap.XSDDateTime
type FooBar struct {
Date *StartDate
}
...
fooBar := FooBar{}
```
It is not possible to access `foobar.Date.ToGoTime()`. This commit
declares the `StartDate` type as follows:
```
type StartDate = soap.XSDDateTime
```
Which allows the complete access to the underlying type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request avoids the hiding of the underlying type and its methods. A use case would be to access the methods of
soap.XSDDateTime. Consider the following code:It is not possible to access
foobar.Date.ToGoTime(). This commit declares theStartDatetype as follows:Which allows the complete access to the underlying type.