Skip to content

Conversation

@nevarsin
Copy link

📝 Description

Allow an external Secret or ConfigMap to be added to the gateway Deployment envFrom.
Current implementation forces secrets to be set in clear text in values.yaml while this PR would enable scenarios where e.g. an existing external Secret Management solution is in charge of creating said Secret.

🔗 Related Issue

Fixes #

🚀 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Style/UI update
  • ♻️ Code refactor
  • ⚡ Performance improvement
  • ✅ Test update
  • 🔧 Build configuration change
  • 🧹 Chore

📋 Changes Made

  • Added extraEnvVarsCM and extraEnvVarsSecret elements to values.yaml
  • Add conditional insertion of said elements to gateway Deployment.yaml

🧪 Testing

helm template hoop deploy/helm-chart/chart/gateway --values deploy/helm-chart/chart/gateway/values.yaml

Test Configuration:

  • Browser(s): Not relevant
  • OS: NixOS unstable - Linux 6.17.1

Tests performed:

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed

📸 Screenshots (if applicable)

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

📄 Additional Notes

Didn't run unit tests as app logic is untouched.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nevarsin
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@nevarsin
Copy link
Author

Ping

@nevarsin nevarsin closed this Oct 27, 2025
@nevarsin nevarsin reopened this Oct 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant