feat: secrets manager integration #1193

luanlorenzo · 2025-12-15T13:22:59Z

📝 Description

This pull request introduces UI selector for secrets manager providers to simplify role credentials configuration.

🚀 Type of Change

📋 Changes Made

Connection Method and Credential Source Handling:

Added webapp/connections/views/setup/connection_method.cljs with logic to normalize credential values, infer connection method from sources, and provide UI components for selecting connection method and source. This includes support for manual input, secrets manager, and AWS IAM role, as well as source selectors for environment variable inputs.
Refactored event handling in events/db_events.cljs to store network credentials as maps with both value and source, and to infer/update the credential source based on the selected connection method or secrets manager provider.

Environment Variables Input Improvements:

Updated configuration_inputs.cljs to conditionally render input fields with a left adornment (source selector) when secrets manager is selected, allowing users to choose the source for each environment variable. Also added logic to hide default titles/subtitles when needed. [1] [2]

Form Components Enhancement:

Added input-with-adornment to forms.cljs, a new input component supporting start adornments (such as a dropdown for source selection), and refactored password visibility toggling logic for better reuse.

Documentation Link Updates:

Updated documentation URLs in config.cljs to include a new reference for RDS IAM authentication setup.

Module Imports and Integration:

Integrated the new connection-method module across relevant files for environment variable and event handling. [1] [2]

🧪 Testing

Test Configuration:

Browser(s): Chrome
OS: MacOs

Tests performed:

Unit tests pass
Integration tests pass
Manual testing completed

📸 Screenshots (if applicable)

✅ Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing unit tests pass locally with my changes
I have checked my code and corrected any misspellings

… secrets manager integration

…ion for role edit

…ration

sandromello · 2025-12-15T21:15:14Z

✅ Build Completed with Success, Version=1193.0.0-c0298ba

sandromello · 2025-12-16T13:21:23Z

✅ Build Completed with Success, Version=1193.0.0-8774e04

matheusfrancisco

I noticed that our shadow-cljs config doesn't explicitly set the ClojureScript version, which means it defaults to whatever version shadow-cljs uses. I'd recommend we explicitly specify it because certain features depend on the version.
For example, update-vals is only available in ClojureScript ≥ 1.11.60. Since ClojureScript is backward compatible, upgrading shouldn't break anything in our frontend webapp.
We should add this to our :dependencies in shadow-cljs.edn:
clojure:dependencies
[[org.clojure/clojurescript "1.11.60"]
...]
Reference: https://github.com/hoophq/hoop/blob/main/webapp/shadow-cljs.edn#L5
Without explicitly setting the version, we're at the mercy of shadow-cljs's default, which might not include update-vals or other newer features we need.

webapp/src/webapp/components/forms.cljs

webapp/src/webapp/resources/setup/events/effects.cljs

webapp/src/webapp/resources/setup/events/process_form.cljs

…ustomization

…ration

sandromello · 2025-12-18T14:15:09Z

✅ Build Completed with Success, Version=1193.0.0-04316dc

…ials for improved state management

sandromello · 2025-12-18T14:39:47Z

✅ Build Completed with Success, Version=1193.0.0-ba556ec

…itional rendering

sandromello · 2025-12-18T14:54:31Z

✅ Build Completed with Success, Version=1193.0.0-ba34955

sandromello · 2025-12-18T18:24:45Z

✅ Build Completed with Success, Version=1193.0.0-f7d196f

… file

sandromello · 2025-12-18T18:45:12Z

✅ Build Completed with Success, Version=1193.0.0-fdd4bc8

sandromello · 2025-12-18T19:00:51Z

✅ Build Completed with Success, Version=1193.0.0-e957bf3

sandromello · 2025-12-18T20:33:57Z

✅ Build Completed with Success, Version=1193.0.0-6980338

sandromello · 2025-12-18T20:38:49Z

✅ Build Completed with Success, Version=1193.0.0-a3aaa91

sandromello · 2025-12-19T12:32:04Z

✅ Build Completed with Success, Version=1193.0.0-994294a

…ns and consolidating update logic

sandromello · 2025-12-19T14:45:24Z

✅ Build Completed with Success, Version=1193.0.0-1dd7413

webapp/src/webapp/connections/views/setup/events/db_events.cljs

webapp/src/webapp/connections/views/setup/configuration_inputs.cljs

webapp/src/webapp/connections/views/setup/connection_method.cljs

webapp/src/webapp/resources/setup/connection_method.cljs

…ng a helper function

sandromello · 2025-12-19T21:04:05Z

✅ Build Completed with Success, Version=1193.0.0-7028fcf

…up views

sandromello · 2025-12-19T21:20:22Z

✅ Build Completed with Success, Version=1193.0.0-e6de37c

sandromello · 2025-12-22T12:41:56Z

✅ Build Completed with Success, Version=1193.0.0-e687b93

sandromello · 2025-12-22T14:32:08Z

✅ Build Completed with Success, Version=1193.0.0-c00ef8e

sandromello · 2025-12-22T15:00:17Z

✅ Build Completed with Success, Version=1193.0.0-74e1f92

sandromello · 2025-12-22T15:03:16Z

✅ Build Completed with Success, Version=1193.0.0-e687b93

rogefm · 2025-12-23T14:23:31Z

webapp/src/webapp/connections/views/setup/events/db_events.cljs

+           updated-db (cond
+                        ;; Update metadata-credentials if field exists there
+                        (contains? metadata-credentials field-key)
+                        (assoc-in db [:connection-setup :metadata-credentials field-key]
+                                  {:value (if (map? metadata-value)
+                                            (:value metadata-value)
+                                            (or metadata-value ""))
+                                   :source source})
+
+                        ;; Update SSH credentials if field exists there
+                        (contains? ssh-credentials field-key-str)
+                        (assoc-in db [:connection-setup :ssh-credentials field-key-str]
+                                  {:value (if (map? ssh-value)
+                                            (:value ssh-value)
+                                            (or ssh-value ""))
+                                   :source source})
+
+                        ;; Update Kubernetes token if field exists there
+                        (contains? kubernetes-token field-key-kw)
+                        (assoc-in db [:connection-setup :kubernetes-token field-key-kw]
+                                  {:value (if (map? kubernetes-value)
+                                            (:value kubernetes-value)
+                                            (or kubernetes-value ""))
+                                   :source source})


Here is a cond that does the same thing in all conditions

webapp/src/webapp/connections/views/setup/server.cljs

rogefm · 2025-12-23T19:29:25Z

The input is not accepting more than one character when you try to insert at the beginning.

rogefm · 2025-12-23T19:31:57Z

Some resource types don't have env variables.

…er handling of adornments in forms

sandromello · 2025-12-24T14:29:13Z

✅ Build Completed with Success, Version=1193.0.0-76d5d2f

sandromello · 2025-12-24T15:45:26Z

✅ Build Completed with Success, Version=1193.0.0-e348777

…environment variables

sandromello · 2025-12-29T18:05:19Z

✅ Build Completed with Success, Version=1193.0.0-390c405

luanlorenzo added 3 commits December 13, 2025 12:46

fix: swap active tab labels for resources and roles

4e0afac

feat: enhance role configuration with connection method selection and…

2cc5e0b

… secrets manager integration

feat: implement credential normalization and connection method select…

af77abe

…ion for role edit

luanlorenzo self-assigned this Dec 15, 2025

luanlorenzo added 2 commits December 15, 2025 18:04

fix: prefix being applied in config-files

46b6c32

Merge branch 'main' into luan/eng-38-new-ux-for-secrets-manager-integ…

c0298ba

…ration

luanlorenzo requested review from EmanuelJr and rogefm December 15, 2025 21:05

feat: enhance AWS IAM role handling in credential processing

8774e04

matheusfrancisco reviewed Dec 16, 2025

View reviewed changes

luanlorenzo added 2 commits December 18, 2025 11:03

feat: update source logic for secrets manager integration and field c…

2864d74

…ustomization

Merge branch 'main' into luan/eng-38-new-ux-for-secrets-manager-integ…

04316dc

…ration

luanlorenzo added 2 commits December 18, 2025 11:27

refactor: introduce functions to update field sources in role credent…

ba556ec

…ials for improved state management

refactor: extract-value for more clean implementation

f55035c

refactor: simplify form component layout by removing unnecessary cond…

ba34955

…itional rendering

fix: add secrets managements to all roles edit form

f7d196f

refactor: move connectio_method components and helpers to a different…

fdd4bc8

… file

fix: prevent prefix being applied to config-files

e957bf3

feat: apply connection method to environment-variables-section

6980338

luanlorenzo requested a review from matheusfrancisco December 18, 2025 20:23

refactor: remove unnecessary logic for config-files

a3aaa91

fix: properly handle remote_url changes on secrets manager input

994294a

refactor: enhance credential management by introducing helper functio…

1dd7413

…ns and consolidating update logic

rogefm requested changes Dec 19, 2025

View reviewed changes

luanlorenzo added 3 commits December 19, 2025 15:28

fix: revert credential updates logic

6080503

refactor: streamline environment variable source updates by introduci…

33c25eb

…ng a helper function

refactor: heading and subtitle rendering into a single condition

7028fcf

refactor: simplify connection method and field source handling in set…

e6de37c

…up views

luanlorenzo requested a review from rogefm December 19, 2025 21:11

refactor: connection_method components structure

e687b93

luanlorenzo force-pushed the luan/eng-38-new-ux-for-secrets-manager-integration branch from 74e1f92 to e687b93 Compare December 22, 2025 14:54

rogefm reviewed Dec 23, 2025

View reviewed changes

refactor: replace input-with-adornment with input component for clean…

76d5d2f

…er handling of adornments in forms

fix: properly handle ssh and httpproxy connection method extraction

e348777

fix: conditionally render connection method based on credentials and …

390c405

…environment variables

feat: secrets manager integration #1193

Are you sure you want to change the base?

feat: secrets manager integration #1193

Uh oh!

Conversation

luanlorenzo commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

🚀 Type of Change

📋 Changes Made

🧪 Testing

Test Configuration:

Tests performed:

📸 Screenshots (if applicable)

✅ Checklist

Uh oh!

sandromello commented Dec 15, 2025

Uh oh!

sandromello commented Dec 16, 2025

Uh oh!

matheusfrancisco left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 18, 2025

Uh oh!

sandromello commented Dec 19, 2025

Uh oh!

sandromello commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sandromello commented Dec 19, 2025

Uh oh!

sandromello commented Dec 19, 2025

Uh oh!

sandromello commented Dec 22, 2025

Uh oh!

sandromello commented Dec 22, 2025

Uh oh!

sandromello commented Dec 22, 2025

Uh oh!

sandromello commented Dec 22, 2025

Uh oh!

rogefm Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rogefm commented Dec 23, 2025

Uh oh!

rogefm commented Dec 23, 2025

Uh oh!

sandromello commented Dec 24, 2025

Uh oh!

sandromello commented Dec 24, 2025

Uh oh!

luanlorenzo commented Dec 15, 2025 •

edited

Loading

matheusfrancisco left a comment •

edited

Loading