Skip to content

Add option for custom Ingress annotations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add option for custom Ingress annotations #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd086e9
feat(helm-charts): ingress annotations
sim500 Feb 23, 2025
932cdcf
ref: ingress annotations
sdaraio Feb 24, 2025
b5cabbb
feat(docs): updated README with ingress annotations
AlePini Mar 28, 2025
1bfe875
fix(helm-charts): typo in ingress annotation
AlePini Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/shc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Update the URLs for mainHost, backendHost, adminHost and related urls in the `va
mainHost: frontend.yourdomain.com
adminHost: admin.yourdomain.com
backendHost: backend.yourdomain.com
annotations: {}
```
when **subpath is enabled**. Only update the mainHost and related urls:
```yaml
Expand All @@ -58,6 +59,7 @@ when **subpath is enabled**. Only update the mainHost and related urls:
# - Main: yourdomain.com
# - Backend: yourdomain.com/backend
# - Admin: yourdomain.com/admin
annotations: {}
```

## Configuration
Expand Down
5 changes: 4 additions & 1 deletion charts/shc/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ metadata:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/ssl-redirect: "false"
{{- end }}
{{- with .Values.service.ingress.annotations }}
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
ingressClassName: {{ .Values.service.ingress.className | default "nginx" }}

Expand Down Expand Up @@ -99,4 +102,4 @@ spec:
port:
number: 3170
{{- end }}
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions charts/shc/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ service:
adminHost: admin.example.com
backendHost: backend.example.com
className: nginx # nginx, alb, traefik
annotations: {}

# TLS Configuration
tls:
Expand Down