fix: add toYaml for extraTls in ingress templates#62
Open
davidloz wants to merge 1 commit into
Open
Conversation
The extraTls field is an array but was being passed directly to nindnet, causing template rendering to fail.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Helm ingress template rendering for Hoppscotch by correctly serializing the extraTls array to YAML before indenting, matching how other “extra*” ingress fields are rendered.
Changes:
- Render
*.ingress.extraTlswithtoYaml | nindent(instead ofnindentdirectly) to avoid Helm type/rendering errors. - Apply the same fix across frontend, backend, admin, and aio ingress templates for consistent behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/hoppscotch/templates/frontend/ingress.yaml | Serialize frontend.ingress.extraTls with toYaml before indenting under spec.tls. |
| charts/hoppscotch/templates/backend/ingress.yaml | Serialize backend.ingress.extraTls with toYaml before indenting under spec.tls. |
| charts/hoppscotch/templates/aio/ingress.yaml | Serialize aio.ingress.extraTls with toYaml before indenting under spec.tls. |
| charts/hoppscotch/templates/admin/ingress.yaml | Serialize admin.ingress.extraTls with toYaml before indenting under spec.tls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extraTls field is an array but was being passed directly to nindnet, causing template rendering to fail.
This fix adds the toYaml function to properly convert the array to YAML before indenting, consistent with how extraRules and extraPaths are handled in the same templates.