Skip to content

feature: added WebSocket support using originList | fix: updated build scripts and rewrote development instructions #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aaronjeromsky
Copy link

@aaronjeromsky aaronjeromsky commented Feb 21, 2025

feature: added WebSocket support using originList

Author: @Saelra

Summary

If a new WebSocket URL is added to originList, the script will connect to it while ensuring the previous connection (if any) is closed first.

If no WebSocket URL is found in originList, the active WebSocket connection is closed and activeWebSocket is set to null to ensure no further actions on a closed connection.

How to Test

  • Add a WebSocket URL to originList and verify that the connection is established.
  • Remove the WebSocket URL from originList and confirm that the WebSocket connection is closed

Expected Behavior

The WebSocket should connect when a new URL is added and WebSocket connections should should be close after a URL is removed.


fix: updated build scripts and rewrote development instructions

Author: @aaronjeromsky and @jjemi8884

Problem

Me and my team at CodeDay encountered a command not found error when executing the build scripts from the HOPP_EXTENSION_TARGET command. In addition, the copyfiles command fails to execute, resulting in an incomplete build output to the dist folder. And the mergeManifest.js file does not complete as expected since whitespace in the HOPP_EXTENSION_TARGET is being read, causing it to not be recognized.

Solution

A set statement has been added to the beginning of the build scripts to allow for the HOPP_EXTENSION_TARGET system variable to be set. A second && has been added between the parcel and copyfiles commands to ensure each one is executed sequentially. And the code to read the HOPP_EXTENSION_TARGET has been updated to ignore whitespace using trim().

Additional Changes

The development section of the documentation has been rewritten with the goal of providing additional clarity for the build instructions, such as specifying the usage of a Git Bash command-line. In our testing, the PowerShell environment was unable to run either version of the build scripts due to requiring a different syntax for handling sequential lines.

Summary

  • Add set to beginning of build scripts
  • Add && before copyfiles command in build scripts
  • Add trim() to HOPP_EXTENSION_TARGET when read as string
  • Rewrote development instructions for clarity

@aaronjeromsky aaronjeromsky changed the title fix: updated build scripts and rewrote development instructions feature: added WebSocket support using originList | fix: updated build scripts and rewrote development instructions Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants