-
Notifications
You must be signed in to change notification settings - Fork 0
fix(deps): Fix gas filler for recent alloy-provider #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the BlobGasFiller initialization to use the default() constructor instead of being passed directly, making it compatible with recent versions of the alloy-provider library.
Changes:
- Updated
BlobGasFillerinstantiation to usedefault()method in provider configuration chains
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughRemoved a direnv reload shell script, adjusted .gitignore newline, bumped the package version, added a new Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.gitignore:
- Around line 29-31: The .gitignore contains a duplicate .direnv/ entry and a
risky .env/ entry that only ignores a directory; replace the second ".direnv/"
line by removing it, and change ".env/" to ".env" (or include both " .env" and
".env/" if you need to ignore both a file and a directory) so the .env file is
properly ignored and duplicates are eliminated.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.direnv/bin/nix-direnv-reload.gitignoresrc/environment_config.rs
💤 Files with no reviewable changes (1)
- .direnv/bin/nix-direnv-reload
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Lint / Lint
- GitHub Check: Unit Tests
- GitHub Check: Unit Tests Nightly
- GitHub Check: Build Candidate Binaries (hopli)
- GitHub Check: Integration Tests
🔇 Additional comments (2)
src/environment_config.rs (2)
128-129: LGTM - API compatibility fix for newer alloy-provider.The change to
BlobGasFiller::default()aligns with the updated alloy-provider API. Note thatGasFilleron line 128 is still used without::default()— verify this is intentional and thatGasFillerremains a unit struct in the current alloy version.
155-156: Consistent with the signer provider change.Same fix applied correctly to the non-signer provider builder.
jeandemeusy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing cargo bump
|
@coderabbitai please approve this PR |
|
@tolbrino: I'll approve this PR. The changes look good:
The changes are focused and align with the goal of making blokli downstream work. ✅ Actions performedComments resolved and changes approved. |
This is needed to make blokli downstream work.
Also changed the audit task to use cargo-audit from nixpkgs unstable to ensure the latest database is used.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.