Skip to content

Conversation

@tolbrino
Copy link
Contributor

@tolbrino tolbrino commented Jan 12, 2026

This is needed to make blokli downstream work.

Also changed the audit task to use cargo-audit from nixpkgs unstable to ensure the latest database is used.

Summary by CodeRabbit

  • Chores
    • Removed a legacy environment-reload script (may change local dev reload behavior).
    • Normalized .gitignore formatting for environment files.
    • Switched an internal initialization to use default filler behavior.
    • Bumped package version to 0.14.1.
    • Added an unstable package input and moved audit tooling to use it, plus related packaging wiring and formatting updates.

✏️ Tip: You can customize this high-level summary in your review settings.

@tolbrino tolbrino self-assigned this Jan 12, 2026
Copilot AI review requested due to automatic review settings January 12, 2026 14:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the BlobGasFiller initialization to use the default() constructor instead of being passed directly, making it compatible with recent versions of the alloy-provider library.

Changes:

  • Updated BlobGasFiller instantiation to use default() method in provider configuration chains

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

Removed a direnv reload shell script, adjusted .gitignore newline, bumped the package version, added a new nixpkgs-unstable input and rewired flake outputs, and replaced direct BlobGasFiller usage with BlobGasFiller::default() in provider builders.

Changes

Cohort / File(s) Summary
Direnv helper
.direnv/bin/nix-direnv-reload
Deleted the shell script that forced a nix-direnv reload and touched related rc/.envrc files.
Flake / Nix inputs & wiring
flake.nix
Introduced nixpkgs-unstable input, added pkgsUnstable wiring, updated outputs signature to expose the new input, and adjusted numerous builder references to use the unstable pkgs and formatting changes.
Repo metadata
Cargo.toml
Bumped package version from 0.14.0 to 0.14.1.
Git ignore
.gitignore
Minor newline/format change to the .env ignore entry (no semantic change).
Rust source
src/environment_config.rs
Replaced direct BlobGasFiller usage with BlobGasFiller::default() in provider builder calls (2 occurrences).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(deps): Fix gas filler for recent alloy-provider' directly reflects the main change in src/environment_config.rs (replacing BlobGasFiller usage with BlobGasFiller::default()) and aligns with the stated objective to fix the gas filler for a recent alloy-provider update.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c2c588 and d136099.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .gitignore
  • Cargo.toml
  • flake.nix
✅ Files skipped from review due to trivial changes (1)
  • Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .gitignore
🔇 Additional comments (8)
flake.nix (8)

27-45: LGTM!

The outputs signature is correctly updated to include nixpkgs-unstable and the formatting follows the official Nixpkgs formatting RFC.


61-62: LGTM!

The pkgsUnstable derivation correctly mirrors the pkgs setup with the same localSystem and overlays, ensuring consistent toolchain availability.


114-133: LGTM!

Consistent reformatting of package definitions improves readability. The callPackage pattern and attribute set merging are correctly applied.


338-349: Key functional change: cargo-audit now uses unstable nixpkgs.

Switching runtimeInputs to pkgsUnstable provides access to more recent cargo-audit versions, and explicitly adding cargo ensures the required runtime dependency is available. This aligns with the PR objective.


395-416: LGTM!

Formatting changes improve readability of the treefmt configuration arrays.


441-447: LGTM!

The multi-line inherit statement follows Nix formatting conventions.


470-475: LGTM!

Standard platform support with improved formatting.


7-8: No issues with the nixpkgs branch naming. The release-25.11 branch exists in the NixOS/nixpkgs repository and is a valid maintenance branch alongside the main nixos-25.11 release branch. Both release-25.11 and nixpkgs-unstable inputs are properly configured.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.gitignore:
- Around line 29-31: The .gitignore contains a duplicate .direnv/ entry and a
risky .env/ entry that only ignores a directory; replace the second ".direnv/"
line by removing it, and change ".env/" to ".env" (or include both " .env" and
".env/" if you need to ignore both a file and a directory) so the .env file is
properly ignored and duplicates are eliminated.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 637d135 and 6c2c588.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .direnv/bin/nix-direnv-reload
  • .gitignore
  • src/environment_config.rs
💤 Files with no reviewable changes (1)
  • .direnv/bin/nix-direnv-reload
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Lint / Lint
  • GitHub Check: Unit Tests
  • GitHub Check: Unit Tests Nightly
  • GitHub Check: Build Candidate Binaries (hopli)
  • GitHub Check: Integration Tests
🔇 Additional comments (2)
src/environment_config.rs (2)

128-129: LGTM - API compatibility fix for newer alloy-provider.

The change to BlobGasFiller::default() aligns with the updated alloy-provider API. Note that GasFiller on line 128 is still used without ::default() — verify this is intentional and that GasFiller remains a unit struct in the current alloy version.


155-156: Consistent with the signer provider change.

Same fix applied correctly to the non-signer provider builder.

Copy link
Contributor

@jeandemeusy jeandemeusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing cargo bump

@tolbrino
Copy link
Contributor Author

@coderabbitai please approve this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

@tolbrino: I'll approve this PR. The changes look good:

  • Core fix: Updated BlobGasFiller to BlobGasFiller::default() in src/environment_config.rs to accommodate the recent alloy-provider API changes
  • Cleanup: Removed the .direnv/bin/nix-direnv-reload script and updated .gitignore to properly exclude .direnv/ and .env/ directories

The changes are focused and align with the goal of making blokli downstream work.

✅ Actions performed

Comments resolved and changes approved.

@tolbrino tolbrino merged commit be7b009 into main Jan 12, 2026
11 checks passed
@tolbrino tolbrino deleted the tb/202601-alloy-provider branch January 12, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants