Feature/modern dashboard#1106
Merged
Merged
Conversation
…ding links, prefs Critical: - Fix NoReverseMatch on announcement delete (anoun_id → pk in reverse()) - Fix View All leave filter: removed exact date match that missed multi-day leaves - Fix leave row click: HTMX target htmx-modal-target → objectDetailsModalTarget Medium: - Add filter params to all pending approval links (attendance, assets, shift, work type) - Fix employee status pie chart: click event → legendClick, label match for In-Active - Fix chart prefs: load from DB via /dashboard/load-prefs/ when localStorage is empty Low: - Increase announcement limit from 6 to 20 - Fix customize toggle theme: use var(--oh-primary) instead of hardcoded indigo
…s, check-in Announcements: - Fix NoReverseMatch on delete (anoun_id → pk in reverse()) - Replace custom modal with standard #objectCreateModal via HTMX - Fixes multi-select/Select2/filter not loading (standard modal lifecycle) - Fixes duplicate record creation (HTMX handles single submission) - Increase listing limit from 6 to 20 On Leave Today: - Fix View All filter: removed exact date match that missed multi-day leaves - Fix row click: HTMX target #htmx-modal-target → #objectDetailsModalTarget Pending Approvals: - Add filter params to all links (attendance, assets, shift, work type, reimbursements) Customize Dashboard: - Fix toggle theme color: use var(--oh-primary) instead of hardcoded indigo - Load chart prefs from DB when localStorage is empty Overview Charts: - Fix employee status pie chart: inactive segment now redirects to is_active=false - Fix recruitment chart tooltip on first load (requestAnimationFrame) Holidays: - Include ongoing holidays in dashboard card (start_date <= today <= end_date) Navbar: - Fix check-in/out button swap: add employee.refresh_from_db() after clock_in/clock_out
…charts, navbar Announcements (8 fixes): - Fix NoReverseMatch on delete (anoun_id → pk in reverse()) - Fix delete last announcement crash (empty pk → close modal gracefully) - Fix deleted object access (AttributeError → not_found guard + message) - Replace custom modal with standard #objectCreateModal via HTMX - Fixes multi-select/Select2/filter not loading (standard modal lifecycle) - Fixes duplicate record creation (HTMX handles single submission) - Fix details modal border styling (lightgrey → var(--border-dark-50)) - Increase listing limit from 6 to 20 On Leave Today (2 fixes): - Fix View All filter: removed exact date match that missed multi-day leaves - Fix row click + next/prev: HTMX target → #objectDetailsModalTarget Pending Approvals (1 fix): - Add filter params to all links (attendance, assets, shift, work type) Holidays (1 fix): - Include ongoing holidays in card (start_date <= today <= end_date) Customize Dashboard (2 fixes): - Fix toggle theme color: use var(--oh-primary) instead of hardcoded indigo - Load chart prefs from DB when localStorage is empty Overview Charts (2 fixes): - Fix employee status pie chart: inactive now redirects to is_active=false - Fix recruitment chart tooltip on first load (requestAnimationFrame) Navbar (1 fix): - Fix check-in/out swap: add employee.refresh_from_db() after clock_in/out
…s, leave filter, holidays & UI fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##NOTE: this file should be inside .github folder in root folder
Description
Please include a summary of the change. List any dependencies that are required for this change.
Ticket Link
Summary of Changes
Additional implementation details (OPTIONAL)
Deployment Notes (OPTIONAL)
Screenshot
Before
After