Merged
Conversation
* Fixed issue when disabled schedule reverts back to enabled upon reboot. That is due to `winter_mode` switch restores to OFF (apparently, when winter mode is disabled) triggering its `turn_off_action`, which turns off both controls to disable lawn and flowerbed sprinklers. The issue manifests itself only when winter mode is disabled. The fix is to introduce the internal switches (for each of user-visible controls disabling each of schedules), those aggregate state of winter mode and the corresponding user-visible switch. The intermediate entity is then controlled by `winter_mode` switch, and prevents that affecting the state of the schedule might have been set by the user.
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where disabled schedules would revert to enabled state after device reboot due to the winter mode switch restoration behavior affecting user-configured schedule states.
- Introduces intermediate aggregate switches that combine winter mode state with user-visible schedule disable switches
- Updates references to use the new aggregate switches instead of direct user switches
- Prevents winter mode restoration from overriding user-configured schedule preferences
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| schedule.yaml | Added aggregate template switches that combine winter mode and user schedule states, updated schedule references |
| controllers.yaml | Updated winter mode actions to control aggregate switches instead of direct user switches |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue when disabled schedule reverts back to enabled upon reboot. That is due to
winter_modeswitch restores to OFF (apparently, when winter mode is disabled) triggering itsturn_off_action, which turns off both controls to disable lawn and flowerbed sprinklers. The issue manifests itself only when winter mode is disabled.The fix is to introduce the internal switches (for each of user-visible controls disabling each of schedules), those aggregate state of winter mode and the corresponding user-visible switch. The intermediate entity is then controlled by
winter_modeswitch, and prevents that affecting the state of the schedule might have been set by the user.