Skip to content

HGI-8761 | Prefer column title over schema mapping #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiorB-D merged 2 commits into from
Sep 12, 2025
Merged

HGI-8761 | Prefer column title over schema mapping #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de7e6a
Prefer column title over schema mapping
LiorB-D Sep 12, 2025
6c495c8
Fix space stripping
LiorB-D Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,4 @@ cython_debug/
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/
.vscode
.DS_Store
6 changes: 5 additions & 1 deletion tap_quickbooks/quickbooks/reportstreams/BaseReport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ def _get_column_metadata(self, resp, schema=None):
LOGGER.info(f"Metadata for col {column.get('ColTitle')} not found, skipping.")
continue
# append col to columns
columns.append(schema.get(col_type))
col_title = column.get("ColTitle")
if col_title in schema.values():
columns.append(col_title.replace(" ", ""))
else:
columns.append(schema.get(col_type))
else:
if column.get("ColTitle") == "Memo/Description":
columns.append("Memo")
Expand Down
2 changes: 1 addition & 1 deletion tap_quickbooks/quickbooks/reportstreams/english_schemas/GeneralLedgerReportFields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"rate": "Rate",
"account_name": "Account",
"split_acc": "Split",
"inv_date": "Invoice Date",
"inv_date": "InvoiceDate",
"is_ar_paid": "A/RPaid",
"is_ap_paid": "A/PPaid",
"is_cleared": "Clr",
Expand Down