Make sql trigger func modular so they do not interfere with one another#11
Merged
spwoodcock merged 1 commit intomainfrom Jun 19, 2025
Merged
Make sql trigger func modular so they do not interfere with one another#11spwoodcock merged 1 commit intomainfrom
spwoodcock merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hotosm/field-tm#2569
Makes the SQL trigger function construction modular, only enabling the
CASE / WHENfor each event, if they are specified in the webhook URLs.Workaround to ensure trigger works for all entity updates and submission reviews, even if the submission XML is large (avoids running submission create trigger). Until #9 is fixed.
@renatocava this doesn't fix the issue for using the
submission.createevent, but it will prevent the webhook breaking if the submission XML is large and you are usingsubmission.updateorentity.updateevents, so it's a partial fix 👍