feat(geomltoolkits): integration with geomltoolkits for modularization#11
Merged
kshitijrajsharma merged 18 commits intomasterfrom Mar 26, 2025
Merged
feat(geomltoolkits): integration with geomltoolkits for modularization#11kshitijrajsharma merged 18 commits intomasterfrom
kshitijrajsharma merged 18 commits intomasterfrom
Conversation
…nd Python version
…y management and package publishing
There was a problem hiding this comment.
Pull Request Overview
This PR integrates geomltoolkits for modularizing prediction-related functionality and removes legacy modules.
- Updates pyproject.toml to include geomltoolkits and switch to Poetry for dependency management.
- Removes deprecated modules (downloader.py, georeferencer.py, raster2polygon.py, vectorizer.py) and updates predictor/app.py to use geomltoolkits functions.
- Adapts API endpoints and tests to asynchronous execution and streamlines model prediction functions.
Reviewed Changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates project metadata and dependencies including geomltoolkits. |
| predictor/utils.py | Refactors imports and adds georeference_prediction_tiles implementation. |
| API/main.py | Updates API configuration and middleware; adds asynchronous endpoints. |
| predictor/prediction.py | Refactors prediction functions to use new toolkit functions and adjusts tensor extraction. |
| predictor/app.py | Updates prediction workflow to use geomltoolkits for tile downloading and georeferencing. |
| Various test and GitHub Actions | Updates workflows and tests for Poetry and async execution; removes legacy build files. |
Files not reviewed (3)
- API/requirements.txt: Language not supported
- Dockerfile: Language not supported
- yolo-requirements.txt: Language not supported
Comments suppressed due to low confidence (1)
predictor/prediction.py:193
- The variable 'image_batch' is undefined in the 'keras' branch; replace it with 'image_paths' to ensure the correct set of images is processed.
predict_keras(model, image_batch, confidence)
…in prediction API
…e code formatting in predictor app
…efault tms_url in predict function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?